Issue 884588 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	szager@chromium.org
Closed:	Oct 29
Cc:	mstensho@chromium.org kojii@chromium.org
Components:	Blink>Layout
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Feature

[css-text] text-indent percentage should be resolved against the block's own content-box inline-size

Project Member Reported by mpalmg...@mozilla.com, Sep 17

Issue description

Chrome Version: 70.0.3534.4 (Official Build) dev (64-bit)
OS: Linux

What steps will reproduce the problem?
(1)load the attached testcase
(2)
(3)

What is the expected result?
text is indented 20px

What happens instead?
text is indented 50px

CSSWG resolution:
https://github.com/w3c/csswg-drafts/issues/2394#issuecomment-380429078

github-issue-2394.html
457 bytes View Download

Comment 1 by e...@chromium.org, Sep 25

Owner: kojii@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by foolip@chromium.org, Oct 9

Tests in https://github.com/web-platform-tests/wpt/pull/11373

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e60301374d325a6cafd2942b4bf6197432c0015a

commit e60301374d325a6cafd2942b4bf6197432c0015a
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Wed Oct 10 12:50:04 2018

Import wpt@434ca4744845966d5f3f87355f41ccc6f777376f (manual)

Using wpt-import in Chromium df7ba195913732e773ac78b838f5226aa094866f.
With Chromium commits locally applied on WPT:
65d72632bf "Make DTMF tone change more deterministic"

Based on https://chromium-review.googlesource.com/1270479 which failed
due to  issue 893079 .

TBR=robertma@chromium.org

Bug:  893079 , 893490,  884588 , 893480
Change-Id: I4fbdb2dc8f5353692e11de3689ad0462c702f496
No-Export: true
Reviewed-on: https://chromium-review.googlesource.com/c/1269732
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598294}
[modify] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
[modify] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-grid/abspos/support/grid.css
[modify] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-grid/grid-definition/support/grid.css
[modify] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-grid/grid-model/support/grid.css
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/text-indent/reference/text-indent-percentage-002-ref.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/text-indent/text-indent-percentage-002.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/text-indent/text-indent-percentage-003.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/text-indent/text-indent-percentage-004.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-000.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-001.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-002.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-003.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-004.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-005.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-006.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-007.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-008.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-00B.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-00D.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-00E.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-00F.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-010.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-011.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-012.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-013.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-014.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-015.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-016.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-017.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-018.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-019.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-01A.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-01B.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-01C.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-01D.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-01E.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-01F.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-07F.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-080.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-081.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-082.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-083.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-084.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-085.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-086.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-087.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-088.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-089.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-08A.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-08B.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-08C.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-08D.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-08E.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-08F.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-090.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-091.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-092.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-093.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-094.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-095.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-096.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-097.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-098.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-099.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-09A.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-09B.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-09C.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-09D.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-09E.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/control-chars-09F.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/reference/control-chars-000-ref.html
[modify] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/css/support/grid.css
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/metadata/infrastructure/testdriver/actions/elementPosition.html.ini
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/metadata/infrastructure/testdriver/actions/elementTiming.html.ini
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/metadata/infrastructure/testdriver/actions/eventOrder.html.ini
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/metadata/infrastructure/testdriver/actions/multiDevice.html.ini
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/elementPosition.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/elementTiming.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/eventOrder.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/multiDevice.html
[add] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/resources/testdriver-actions.js
[modify] https://crrev.com/e60301374d325a6cafd2942b4bf6197432c0015a/third_party/WebKit/LayoutTests/external/wpt/resources/testdriver.js

Comment 4 by kojii@chromium.org, Oct 14

Cc: kojii@chromium.org
Labels: -Type-Bug Type-Feature
Owner: ----
Status: Available (was: Assigned)

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/687519942e2eadb53ed50cce64d7607c24fa6444

commit 687519942e2eadb53ed50cce64d7607c24fa6444
Author: Stefan Zager <szager@chromium.org>
Date: Fri Oct 19 00:27:01 2018

Use content width to calculate percentage text-indent

The new line in TestExpectations is for an old WPT test that checks
for the old behavior.

BUG= 884588 
R=eae@chromium.org

Change-Id: I560e8d240d773536d084b598ac76261f9ecef81a
Reviewed-on: https://chromium-review.googlesource.com/c/1285109
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600989}
[modify] https://crrev.com/687519942e2eadb53ed50cce64d7607c24fa6444/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/687519942e2eadb53ed50cce64d7607c24fa6444/third_party/WebKit/LayoutTests/css2.1/t1601-c547-indent-01-d.html
[modify] https://crrev.com/687519942e2eadb53ed50cce64d7607c24fa6444/third_party/WebKit/LayoutTests/external/wpt/css/css-text/text-indent/reference/text-indent-percentage-002-ref.html
[modify] https://crrev.com/687519942e2eadb53ed50cce64d7607c24fa6444/third_party/WebKit/LayoutTests/external/wpt/css/css-text/text-indent/text-indent-percentage-002.html
[modify] https://crrev.com/687519942e2eadb53ed50cce64d7607c24fa6444/third_party/WebKit/LayoutTests/external/wpt/css/css-text/text-indent/text-indent-percentage-003.html
[modify] https://crrev.com/687519942e2eadb53ed50cce64d7607c24fa6444/third_party/WebKit/LayoutTests/external/wpt/css/css-text/text-indent/text-indent-percentage-004.html
[modify] https://crrev.com/687519942e2eadb53ed50cce64d7607c24fa6444/third_party/blink/renderer/core/layout/layout_block.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54fcb574b739aa7b3a867541a6766ba2559d67f5

commit 54fcb574b739aa7b3a867541a6766ba2559d67f5
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Mon Oct 22 16:51:17 2018

[LayoutNG] Match new spec wrt. percentage text-indent.

It's now to be resolved against the inline-size of the content area of
the block itself [1]. Already fixed for legacy layout here:
https://chromium-review.googlesource.com/c/chromium/src/+/1285109

We no longer need PercentageResolutionInlineSize().

[1] https://github.com/w3c/csswg-drafts/issues/2394#issuecomment-380429078

Bug:  884588 
Change-Id: I7526bbdbab4cfc31cdfb4c8e1d83450e9d1eee1a
Reviewed-on: https://chromium-review.googlesource.com/c/1292874
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601614}
[modify] https://crrev.com/54fcb574b739aa7b3a867541a6766ba2559d67f5/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/54fcb574b739aa7b3a867541a6766ba2559d67f5/third_party/blink/renderer/core/layout/ng/inline/ng_inline_item_result.cc
[modify] https://crrev.com/54fcb574b739aa7b3a867541a6766ba2559d67f5/third_party/blink/renderer/core/layout/ng/ng_constraint_space.cc
[modify] https://crrev.com/54fcb574b739aa7b3a867541a6766ba2559d67f5/third_party/blink/renderer/core/layout/ng/ng_constraint_space.h
[modify] https://crrev.com/54fcb574b739aa7b3a867541a6766ba2559d67f5/third_party/blink/renderer/core/layout/ng/ng_constraint_space_builder.h

Comment 7 by kojii@chromium.org, Oct 29

Cc: mstensho@chromium.org
Owner: szager@chromium.org
Status: Fixed (was: Available)

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79d792a1e6fc047d7b304a9c5b35fc5145666fb2

commit 79d792a1e6fc047d7b304a9c5b35fc5145666fb2
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Fri Nov 02 14:44:44 2018

Percentage text-indent tests have been fixed and now they pass.

Fixes imported here:
https://chromium-review.googlesource.com/c/1314128

Spec change:
https://github.com/w3c/csswg-drafts/issues/2394

TBR=szager@chromium.org

Bug:  884588 
Change-Id: I4e1c9537122817afb9ebe03ad70290a0558f582c
Reviewed-on: https://chromium-review.googlesource.com/c/1314631
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604914}
[modify] https://crrev.com/79d792a1e6fc047d7b304a9c5b35fc5145666fb2/third_party/WebKit/LayoutTests/TestExpectations

►

Issue 884588 link

Issue metadata

[css-text] text-indent percentage should be resolved against the block's own content-box inline-size

Issue description

Comment 1 by e...@chromium.org, Sep 25

Comment 1 Deleted

Comment 2 by foolip@chromium.org, Oct 9

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Oct 10

Comment 3 Deleted

Comment 4 by kojii@chromium.org, Oct 14

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Oct 19

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Oct 22

Comment 6 Deleted

Comment 7 by kojii@chromium.org, Oct 29

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Nov 2

Comment 8 Deleted

Sign in to add a comment