New issue
Advanced search Search tips

Issue 884576 link

Starred by 4 users
Status: Verified
Owner:
nverne@chromium.org
Closed: Sep 28
Cc:
rohi...@chromium.org
avkodipelli@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Crostini startup can hang at the StartVm phase

Project Member Reported by nverne@chromium.org, Sep 17 
If the user has already started a VM via crosh, for instance, then CrostiniManager will hang forever on the next attempt to launch Terminal or an App. This is because it waits for a TremplinStartedSignal from the VM that already happened and won't happen again. 

We can solve this by returning a "RUNNING" status from in the StartVmResponse, in which case CrostiniManager can just use the VM without waiting for Tremplin to start.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14d57280e9d3d1cf45345b47bad3c1408f96b9a1

commit 14d57280e9d3d1cf45345b47bad3c1408f96b9a1
Author: Nicholas Verne <nverne@chromium.org>
Date: Thu Sep 20 06:52:58 2018

Roll src/third_party/cros_system_api/ 48093e267..137cb973f (1 commit)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/48093e2673c6..137cb973fb0e

$ git log 48093e267..137cb973f --date=short --no-merges --format='%ad %ae %s'
2018-09-18 nverne Add VmStatus to StartVmResponse.

Created with:
  roll-dep src/third_party/cros_system_api

Bug:  884576 
Change-Id: I14a5648257e09d87f35b5de0a735c614568cad22
Reviewed-on: https://chromium-review.googlesource.com/1235514
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592705}
[modify] https://crrev.com/14d57280e9d3d1cf45345b47bad3c1408f96b9a1/DEPS

Comment 2 by nverne@chromium.org, Sep 27

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca393e722b94ac0f6f84597a459f981d5e23aaa3

commit ca393e722b94ac0f6f84597a459f981d5e23aaa3
Author: Nicholas Verne <nverne@chromium.org>
Date: Thu Sep 27 08:14:00 2018

CrostiniManager uses status for StartTerminaVm.

Only if the response proto status is "STARTING" do we wait for the
TremplinStartedSignal before continuing.

Bug:  884576 
Change-Id: Id02a5863c2971329991d47bf156639fdc7f281bd
Reviewed-on: https://chromium-review.googlesource.com/1248065
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594629}
[modify] https://crrev.com/ca393e722b94ac0f6f84597a459f981d5e23aaa3/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/ca393e722b94ac0f6f84597a459f981d5e23aaa3/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/ca393e722b94ac0f6f84597a459f981d5e23aaa3/chrome/browser/ui/views/crostini/crostini_installer_view_browsertest.cc
[modify] https://crrev.com/ca393e722b94ac0f6f84597a459f981d5e23aaa3/chromeos/dbus/fake_concierge_client.cc

Comment 4 by nverne@chromium.org, Sep 28

Status: Fixed (was: Started)

Comment 5 by avkodipelli@chromium.org, Oct 8

Cc: rohi...@chromium.org avkodipelli@chromium.org
nverne@ Please provide verification steps. Thanks!

Comment 6 by nverne@chromium.org, Oct 8 

This is a bit unscientific, but:

Old broken build (with Crostini already installed, then reboot):

1. Open crosh (ctrl-alt-t)
2. type "vmc start termina"
3. Go to App Launcher and launch Termina or some other Linux app
4. Spinner appears and spins forever (hang)

New, not broken

4. Spinner appears for a while but eventually app comes up and spinner goes away.

Comment 7 by avkodipelli@chromium.org, Oct 8

Status: Verified (was: Fixed)
Verified on 11137.0.0, 71.0.3567.0 on eve.
►

Sign in to add a comment