New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 884573 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

NTP should highlight offline enabled sites when offline

Project Member Reported by benwells@chromium.org, Sep 16

Issue description

Sites that we think might work offline should be shown first and highlighted. Sites that we know won't work should be shown disabled or hidden.
 
Cc: nancygao@chromium.org janicewong@chromium.org
Labels: OS-Android OS-iOS
Thanks for the feedback!

It's a bit unclear to me what you mean by sites on the NTP. Is this the most recently favicons at the very top? Or the articles you scroll through?

Also unclear, when you say "might work offline", are these pages that have been downloaded and can be opened offline? Or sites that downloading in general will perform poorly on, like pages with videos?

I believe we currently (and plan to continue) show an offlined badge for both top sites and articles. These are the things that can actually be opened when you're offline, and we show this badge regardless of your online status.

If you're talking about articles, prefetching should naturally be fetching the top ones first, so we kind of get this ordering by accident. Though depending on your country, prefetch might be disabled.

I'm fairly hesitant to re-order the articles. There are performance and coordination issues with making this happen, especially with Jardin. And once the articles start displaying, we really don't want to move any UI around.

+janicewong@ +nancygao@
Cc: s...@chromium.org
"might work offline" also includes sites/apps that have installed service workers that will interpret the request, and not produce 404s.

In general, the user should not be surprised when they click on something in the NTP. If we present an enticing option that 404s because the user is offline, we are not doing the right thing. Whether we do that by greying out sites/links/articles that cannot be accessed when the user's device is currently offline, or badging, is a UX/product call (eg greying would not cause UI to move around).

Bug 856420 is a related to this, but for omnibox suggestions.
Labels: -OS-iOS
iOS does not support service workers. Add iOS back if you believe we can help here.
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
I'm referring to the recent sites. Also this is relevant for desktop, so adding in labels for those.

Currently 'might work offline' means (a) has a service worker and (b) the service worker has a fetch handler. That doesn't guarantee it will work offline but without this we can be sure it won't.

I didn't realise we show an offline badge, I've never seen this. I don't think it exists on desktop.
Labels: zine-triaged

Sign in to add a comment