New issue
Advanced search Search tips

Issue 884570 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 884306
Owner: ----
Closed: Sep 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

network_service_browser_tests failing on chromium.win/Win7 Tests (dbg)(1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Sep 16

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of shend@chromium.org

network_service_browser_tests failing on chromium.win/Win7 Tests (dbg)(1)

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29


 
Been kinda flaky since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/71600

Errors look like this:

../../chrome/browser/apps/guest_view/web_view_browsertest.cc(1119): error: Value of: next_step_listener.WaitUntilSatisfied()
  Actual: false
Expected: true
Stack trace:
Backtrace:
	StackTraceGetter::CurrentStackTrace [0x032CBEBA+90]
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x032E2D6A+74]
	testing::internal::AssertHelper::operator= [0x032E287B+75]
	WebViewTest_SpatialNavigationJavascriptAPI_Test::RunTestOnMainThread [0x0100E201+1889]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x0649C0C4+804]
	??$Invoke@P8BrowserTestBase@content@@AEXXZPAV12@$$V@?$FunctorTraits@P8BrowserTestBase@content@@AEXXZX@internal@base@@SAXP8BrowserTestBase@content@@AEXXZ$$QAPAV34@@Z [0x0649E70C+28]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall content::BrowserTestBase::*const &)(void),content::BrowserTestBase *> [0x0649E64F+79]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::RunImpl<void (__thiscall content::BrowserTestBase::*const &)(void),std [0x0649E5E5+85]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::Run [0x0649E4CF+63]
	base::RepeatingCallback<void __cdecl(void)>::Run [0x0104ED02+50]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x07EE0D07+7047]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x07EDF0FE+398]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x5E2021D6+342]
	??$Invoke@P8BrowserMainLoop@content@@AEHXZPAV12@$$V@?$FunctorTraits@P8BrowserMainLoop@content@@AEHXZX@internal@base@@SAHP8BrowserMainLoop@content@@AEHXZ$$QAPAV34@@Z [0x5E20D11C+28]
	base::internal::InvokeHelper<0,int>::MakeItSo<int (__thiscall content::BrowserMainLoop::*const &)(void),content::BrowserMainLoop *> [0x5E20D04F+79]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::RunImpl<int (__thiscall content::BrowserMainLoop::*const &)(void),std::t [0x5E20CFE5+85]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::Run [0x5E20CE8F+63]
	base::RepeatingCallback<int __cdecl(void)>::Run [0x5EC05202+50]
	content::StartupTaskRunner::RunAllTasksNow [0x5F587AF9+137]
	content::BrowserMainLoop::CreateStartupTasks [0x5E1FFE35+1493]
	content::BrowserMainRunnerImpl::Initialize [0x5E2138A4+1908]
	content::BrowserMain [0x5E1F96BD+173]
	content::RunBrowserProcessMain [0x60C6AEED+141]
	content::ContentMainRunnerImpl::Run [0x60C6C0D7+903]
	content::ContentServiceManagerMainDelegate::RunEmbedderProcess [0x60C68872+50]
	service_manager::Main [0x59F43EF3+1811]
	content::ContentMain [0x60C6ADDC+92]
	content::BrowserTestBase::SetUp [0x0649BA89+3097]
	InProcessBrowserTest::SetUp [0x05AF4CD9+1961]
The test that's failing is WebViewTest.SpatialNavigationJavascriptAPI

Nothing obvious stands out in the blame list. Maybe https://chromium-review.googlesource.com/c/chromium/src/+/1214803 ?
Ok, the test was added in the build right before the first failure: https://chromium.googlesource.com/chromium/src/+/e58c9eecce5de4f6e40017d8554d966a1a85644f

So either the test is flaky from the beginning or something in the following build made it flaky. Since there's no obvious culprits in the following build, I think the test is probably flaky from the beginning.
Cc: jaragu...@igalia.com
Going to disable the test.
Mergedinto: 884306
Status: Duplicate (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bf8386c354cf1109cfd924772788432a14b9c36

commit 9bf8386c354cf1109cfd924772788432a14b9c36
Author: Darren Shen <shend@chromium.org>
Date: Mon Sep 17 01:05:23 2018

[sheriff] Disable WebViewTest.SpatialNavigationJavascriptAPI on Win.

TBR=lazyboy@chromium.org,jaragunde@igalia.com

Bug:  884570 
Change-Id: I702f6c8a3f54f6c1b095afbc86b19f096a761b36
Reviewed-on: https://chromium-review.googlesource.com/1226727
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591606}
[modify] https://crrev.com/9bf8386c354cf1109cfd924772788432a14b9c36/chrome/browser/apps/guest_view/web_view_browsertest.cc

Sign in to add a comment