New issue
Advanced search Search tips

Issue 884566 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

generate_build_files failing on chromium.chrome/Google Chrome ChromeOS

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Sep 16

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of shend@chromium.org

generate_build_files failing on chromium.chrome/Google Chrome ChromeOS

Builders failed on: 
- Google Chrome ChromeOS: 
  https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS


 
Several build errors, they look like this:

/b/c/b/Google_Chrome_ChromeOS/src/buildtools/linux64/gn gen //out/Release --check
  -> returned 1
ERROR at //chromeos/assistant/internal/cros_display_connection.cc:7:11: Can't include this header from here.
#include "base/logging.h"
          ^-------------
The target:
  //chromeos/assistant/internal:internal
is including a file from the target:
  //base:base
It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.
Dependency chain (there may also be others):
  //chromeos/assistant/internal:internal -->
  //ui/accessibility:ax_assistant --[private]-->
  //ui/accessibility:accessibility -->
  //base:base

All the errors relate to assistant code, so the culprit is probably 31a94c76a50396172322746151277ac04b0010c1 .

Going to revert it and see.
Cc: vapier@chromium.org xiaoh...@chromium.org
Cc: -xiaoh...@chromium.org -shend@chromium.org
Labels: -Sheriff-Chromium
Owner: xiaoh...@chromium.org
Status: Assigned (was: Available)
Reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1226724

Build's green now.
Status: Fixed (was: Assigned)
Thanks for catching this.  Closing this bug and will create a seperate one to fix the root cause.
Cc: shend@chromium.org
shend@, I am trying to reland the previous CL, do you know how to trigger this builder on CQ?
Hmm, not 100% sure, but try running "gn check out/Release/" where out/Release is is your out directory.
Did that and works now.  Just want to make sure there isn't other issues. If there is no manual way to run the bot with the CL, I will have to submit and try again :)

Sign in to add a comment