generate_build_files failing on chromium.chrome/Google Chrome ChromeOS |
|||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of shend@chromium.org generate_build_files failing on chromium.chrome/Google Chrome ChromeOS Builders failed on: - Google Chrome ChromeOS: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS
,
Sep 16
,
Sep 17
Reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1226724 Build's green now.
,
Sep 17
Thanks for catching this. Closing this bug and will create a seperate one to fix the root cause.
,
Sep 18
shend@, I am trying to reland the previous CL, do you know how to trigger this builder on CQ?
,
Sep 18
Hmm, not 100% sure, but try running "gn check out/Release/" where out/Release is is your out directory.
,
Sep 18
Did that and works now. Just want to make sure there isn't other issues. If there is no manual way to run the bot with the CL, I will have to submit and try again :) |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by shend@chromium.org
, Sep 16Several build errors, they look like this: /b/c/b/Google_Chrome_ChromeOS/src/buildtools/linux64/gn gen //out/Release --check -> returned 1 ERROR at //chromeos/assistant/internal/cros_display_connection.cc:7:11: Can't include this header from here. #include "base/logging.h" ^------------- The target: //chromeos/assistant/internal:internal is including a file from the target: //base:base It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //chromeos/assistant/internal:internal --> //ui/accessibility:ax_assistant --[private]--> //ui/accessibility:accessibility --> //base:base All the errors relate to assistant code, so the culprit is probably 31a94c76a50396172322746151277ac04b0010c1 . Going to revert it and see.