New issue
Advanced search Search tips

Issue 884559 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 884560
issue 883538



Sign in to add a comment

Add support for LLVMFuzzerInitialize LLVMFuzzerCustom* to libFuzzer on Windows

Project Member Reported by metzman@chromium.org, Sep 16

Issue description

Currently these features do not work, causing many targets on Windows to have errors at run time.
 
Blocking: 883538
Blockedon: 884560
Blocking: 884560
Blockedon: -884560
Summary: Add support for LLVMFuzzerInitialize LLVMFuzzerCustom* to libFuzzer on Windows (was: Add support for LLVMFuzzerInitialize LLVMCustom* to libFuzzer on Windows.)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81e5054e56e7d430338201fa95e33c339aca2799

commit 81e5054e56e7d430338201fa95e33c339aca2799
Author: Jonathan Metzman <metzman@chromium.org>
Date: Mon Sep 17 14:18:53 2018

[libfuzzer][Windows] Dont use dynamic loading for external functions.

Doing so doesn't make sense because the only supported fuzzer builds
on Windows are non-component builds.
This patch enables libFuzzer to use user defined functions like
LLVMFuzzerCustomMutator, LLVMFuzzerCustomCrossOver, and
LLVMFuzzerInitialize.

Bug:  884559 
Change-Id: I783e50b1306e37b5a0528fd4aa3cf077cec3bfb4
Reviewed-on: https://chromium-review.googlesource.com/1227616
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591666}
[modify] https://crrev.com/81e5054e56e7d430338201fa95e33c339aca2799/third_party/libFuzzer/BUILD.gn

Status: Verified (was: Started)
Fixed in Chromium. Fix for upstream being reviewed here: https://reviews.llvm.org/D51700
Upstream fix landed yesterday
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20b2e43d7308551b378b93545c7334de36b79c0d

commit 20b2e43d7308551b378b93545c7334de36b79c0d
Author: Jonathan Metzman <metzman@chromium.org>
Date: Wed Sep 26 16:33:55 2018

Roll src/third_party/libFuzzer/src/ a2d200e6a..a305a5eb8 (2 commits)

https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/a2d200e6a..a305a5eb8

$ git log a2d200e6a..a305a5eb8 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 metzman [fuzzer] Replace FuzzerExtFunctionsDlsymWin.cpp with FuzzerExtFunctionsWeakAlias.cpp
2018-09-17 morehouse [libFuzzer] Avoid fuzzer symbols being hidden.


Bug:  884559 
Change-Id: Iabcc2d7517171dc90626b0836953951b289f4322
Reviewed-on: https://chromium-review.googlesource.com/1239460
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594342}
[modify] https://crrev.com/20b2e43d7308551b378b93545c7334de36b79c0d/DEPS
[modify] https://crrev.com/20b2e43d7308551b378b93545c7334de36b79c0d/third_party/libFuzzer/BUILD.gn

Sign in to add a comment