New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 884540 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

goldfishd: build fails after gn migration

Project Member Reported by vapier@google.com, Sep 16

Issue description

this is blocking submission on a few boards:
goldfishd-0.0.1-r276: /build/novato-arc64/tmp/portage/chromeos-base/goldfishd-0.0.1-r276/work/goldfishd-0.0.1/common-mk/platform2.py --libdir=/usr/lib64 --use_flags=abi_x86_64 amd64 cros-debug elibc_glibc kernel_linux test userland_GNU --jobs=32 --action=configure --cache_dir=/build/novato-arc64/var/cache/portage/chromeos-base/goldfishd --platform_subdir=goldfishd /build/novato-arc64/tmp/portage/chromeos-base/goldfishd-0.0.1-r276/work/goldfishd-0.0.1/goldfishd/goldfishd.gyp
goldfishd-0.0.1-r276: 00:42:14: INFO: RunCommand: gn gen '--root=/build/novato-arc64/tmp/portage/chromeos-base/goldfishd-0.0.1-r276/work/goldfishd-0.0.1' '--args=platform_subdir="goldfishd" external_cflags=["-O2","-pipe","-march=x86-64","-msse3","-g","-fno-exceptions","-fno-unwind-tables","-fno-asynchronous-unwind-tables"] external_cppflags=["-D_FILE_OFFSET_BITS=64","-D_LARGEFILE_SOURCE","-D_LARGEFILE64_SOURCE"] enable_exceptions=false build_root="/build/novato-arc64/var/cache/portage/chromeos-base/goldfishd" external_ldflags=["-Wl,-O2","-Wl,--as-needed"] platform2_root="/build/novato-arc64/tmp/portage/chromeos-base/goldfishd-0.0.1-r276/work/goldfishd-0.0.1" external_cxxflags=["-O2","-pipe","-march=x86-64","-msse3","-g","-fno-exceptions","-fno-unwind-tables","-fno-asynchronous-unwind-tables"] OS="linux" libdir="/usr/lib64" libbase_ver="395517" sysroot="/build/novato-arc64" pkg_config="/build/novato-arc64/build/bin/pkg-config" cc="x86_64-cros-linux-gnu-clang" cxx="x86_64-cros-linux-gnu-clang++" ar="x86_64-cros-linux-gnu-ar" use={metrics_uploader=false wifi=false feedback=false cros_debug=true kvm_host=false cros_host=false passive_metrics=false device_mapper=false arm=false systemd=false direncryption=false abi_x86_64=true amd64=true opengles=false fuzzer=false iwlwifi_dump=false cfm_enabled_device=false tpm2_simulator=false pppoe=false containers=false userland_GNU=true hammerd_api=false profiling=false wake_on_wifi=false gdmwimax=false tpm2=false buffet=false kernel_linux=true test=true binder=false wimax=false cellular=false vpn=false tcmalloc=false power_management=false cheets=false chromeos_dbus=false dbus=false ftdi_tpm=false wired_8021x=false attestation=false dhcpv6=false elibc_glibc=true tpm=false mtd=false}' /build/novato-arc64/var/cache/portage/chromeos-base/goldfishd/out/Default in /build/novato-arc64/tmp/portage/chromeos-base/goldfishd-0.0.1-r276/work/goldfishd-0.0.1
goldfishd-0.0.1-r276: ERROR at //goldfishd/BUILD.gn:47:16: Assignment had no effect.
goldfishd-0.0.1-r276:     pkg_deps = [ "libchrome-test-${libbase_ver}" ]
goldfishd-0.0.1-r276:                ^---------------------------------
goldfishd-0.0.1-r276: You set the variable "pkg_deps" here and it was unused before it went
goldfishd-0.0.1-r276: out of scope.
goldfishd-0.0.1-r276: See //common-mk/gn_root/BUILD.gn:14:5: which caused the file to be included.
goldfishd-0.0.1-r276:     "//${platform_subdir}:all",
goldfishd-0.0.1-r276:     ^-------------------------

 
Cc: nya@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cb10a8208a24c3ba35dfcd38d77416aed7d18264

commit cb10a8208a24c3ba35dfcd38d77416aed7d18264
Author: Keigo Oka <oka@chromium.org>
Date: Mon Sep 17 06:47:34 2018

goldfishd: fix build failure

TEST=USE="test asan goldfishd" cros_workon_make --board=eve --test goldfishd
BUG= chromium:884540 
BUG=chromium:767517

Change-Id: I33c308986550c80f7f982a471fd5b746637766a7
Reviewed-on: https://chromium-review.googlesource.com/1226723
Commit-Ready: Keigo Oka <oka@chromium.org>
Tested-by: Keigo Oka <oka@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/cb10a8208a24c3ba35dfcd38d77416aed7d18264/goldfishd/BUILD.gn

Status: Fixed (was: Assigned)
It should be fixed.

Sign in to add a comment