New issue
Advanced search Search tips

Issue 884521 link

Starred by 4 users

Issue metadata

Status: Unconfirmed
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature



Sign in to add a comment

Please make unrar dependency optional

Reported by lant...@gmail.com, Sep 16

Issue description

UserAgent: Mozilla/5.0 (X11; FreeBSD amd64) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/11.0 Safari/605.1.15 Epiphany/605.1.15

Steps to reproduce the problem:
1. Run ./build/linux/unbundle/remove_bundled_libraries.py --do-remove without listing third_party/unrar on the command line.
2. Build it with GN and Ninja.

What is the expected behavior?
Chromium can be built without unrar.

What went wrong?
It doesn't build because safe browsing depends on it. The code handling RAR archives isn't wrapped by #ifdef and it cannot be compiled when third_party/unrar is removed.

Did this work before? Yes 65.0.3325.181

Chrome version: 69.0.3497.92  Channel: stable
OS Version: Fedora 28
Flash Version: 

The source code of unrar is publicly available, but its license is not an open souroce license. Some GNU/Linux distributions, such as Fedora, have policies which disallow including proprietary software in the distributions. Therefore, people who build Chromium packages on services hosted by Fedora are required to remove code that uses unrar.

It was easy in Chromium 66 because it could be done by simply removing 3 lines in the GN file: https://github.com/lantw44/copr-rpm-spec/blob/ab1b40a44b34ed2703a48ec0167add88b746ce70/chromium/chromium/chromium-disable-unrar.patch. However, it becomes harder in Chromium 69: https://github.com/lantw44/copr-rpm-spec/blob/3b83362a966ba0f005fcd9c1054122a72c7ba638/chromium/chromium/chromium-disable-unrar.patch. Is it possible to make the unrar dependency optional in Chromium upstream or provide an option to use a different library such as unarr, so package maintainers are not required to figure out the way to remove unrar on each future release?
 
Labels: Needs-Bisect Needs-Triage-M69
Cc: vamshi.kommuri@chromium.org
Components: Build
Labels: Triaged-ET TE-NeedsTriageHelp
Thanks for filing the issue!

From comment#0 it is understood that the issue seems to be related to building Chromium using GN and Ninja, which is out of scope for us to triage it further from our end. Hence adding label TE-NeedsTriageHelp and requesting someone from respective team to have a look into this.

Sign in to add a comment