New issue
Advanced search Search tips

Issue 884495 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::Frame::DeprecatedLocalOwner

Project Member Reported by ClusterFuzz, Sep 15

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6700049143431168

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x00000018
Crash State:
  blink::Frame::DeprecatedLocalOwner
  blink::WebRemoteFrameImpl::OOPIFHasPointerEventsNone
  content::RenderFrameProxy::HasPointerEventsNone
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=590754:590755

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6700049143431168

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 15

Components: Blink>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Sep 15

Labels: Test-Predator-Auto-Owner
Owner: sunxd@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/c02c059891de67fa3b2ef879a322f5b01db87ab8 (Reland: Do not hit test OOPIFs with pointer-events: none).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: kenrb@chromium.org sadrul@chromium.org
Hi Sadrul and Ken, this is a new clusterfuzz issue. I reproduced it locally and it looks like when setting HasPointerEventsNone in ChildFrameCompositingHelper (https://cs.chromium.org/chromium/src/content/renderer/child_frame_compositing_helper.cc?rcl=5560ff2848c8a09111cc8e2895ca9beb91669a24&l=85), the RenderFrameProxy's web_frame (WebRemoteFrameImpl) does not have a valid Frame(). I thought when we creating a surface layer there should already be a frame, is there anything wrong? Thanks.
I am not familiar with this part of blink. Someone more familiar with that can hopefully provide guidance.
Project Member

Comment 5 by ClusterFuzz, Sep 19

ClusterFuzz has detected this issue as fixed in range 592283:592286.

Detailed report: https://clusterfuzz.com/testcase?key=6700049143431168

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x00000018
Crash State:
  blink::Frame::DeprecatedLocalOwner
  blink::WebRemoteFrameImpl::OOPIFHasPointerEventsNone
  content::RenderFrameProxy::HasPointerEventsNone
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=590754:590755
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=592283:592286

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6700049143431168

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Sep 19

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6700049143431168 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
I think https://chromium.googlesource.com/chromium/src.git/+/02a0bc1278a5f419764a82b8df7b1f5b181d1cbf might fixed this issue. It include cc files in blink/core/renderer and directly call surface layer's setter.

Sign in to add a comment