New issue
Advanced search Search tips

Issue 884444 link

Starred by 1 user
Status: Started
Owner:
pkotw...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add a mechanism for importing Chromium code into WebAPK

Project Member Reported by pkotw...@chromium.org, Sep 15 
https://chromium-review.googlesource.com/c/chromium/src/+/1201348
copies and pastes a lot of code from ApiCompatibilityUtils.java
and ColorUtils.java into webapk/shell_apk.

It would be nice if there was a way of using Chromium code in the WebAPK
without having to copy and paste it.
ApiCompatibilityUtils.java and ColorUtils.java are too generic to put in
//chrome/android/webapk/libs/common
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e44f7638c802e7f3b5386223af75c785ff0c57ca

commit e44f7638c802e7f3b5386223af75c785ff0c57ca
Author: Peter Kotwicz <pkotwicz@chromium.org>
Date: Tue Sep 18 01:20:37 2018

[Android WebAPK] template_shell_apk_version checking for webapk/libs/common

This CL adds a presubmit to require 'template_shell_apk_version' to be
incremented for //chrome/android/webapk/libs/common changes

BUG=884444

Change-Id: I5b389dcb721b5aa7ef8567015ad54d2c4d0e178d
Reviewed-on: https://chromium-review.googlesource.com/1227599
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591909}
[add] https://crrev.com/e44f7638c802e7f3b5386223af75c785ff0c57ca/chrome/android/webapk/PRESUBMIT.py
[add] https://crrev.com/e44f7638c802e7f3b5386223af75c785ff0c57ca/chrome/android/webapk/PRESUBMIT_test.py
[delete] https://crrev.com/6743b311b27c3aa19edf2d329e683affb9c5dc17/chrome/android/webapk/shell_apk/PRESUBMIT.py
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/b025be85c41c4151f6959a402182ad94789e72b9

commit b025be85c41c4151f6959a402182ad94789e72b9
Author: Peter Kotwicz <pkotwicz@chromium.org>
Date: Thu Sep 27 20:29:19 2018
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f35338b71bcf13dad9e199f6fae519fbcef5d555

commit f35338b71bcf13dad9e199f6fae519fbcef5d555
Author: Peter Kotwicz <pkotwicz@chromium.org>
Date: Mon Oct 01 22:15:21 2018

[Android WebAPK] Add build step checking current_shell_apk_version is updated 2/3

The goal of this "CL set" (1-3) is to:
- Force people to update template_shell_apk_version when code which is
  compiled into WebApk.apk is updated
- Don't require additional reviewers for updating template_shell_apk_version.

This CL:
- Moves template_shell_apk_version into into a new file in a directory where
  it is the only file.
- Adds an OWNERS file to allow anyone to update template_shell_apk_version.
- Renames template_shell_apk_version and expected_shell_apk_version so that
  the GN variable names are more intuitive

BUG=884444

Change-Id: Ic7a15506511f2bbffe2beea04d51e1a6e6d1aed5
Reviewed-on: https://chromium-review.googlesource.com/1243669
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595575}
[modify] https://crrev.com/f35338b71bcf13dad9e199f6fae519fbcef5d555/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
[modify] https://crrev.com/f35338b71bcf13dad9e199f6fae519fbcef5d555/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java
[modify] https://crrev.com/f35338b71bcf13dad9e199f6fae519fbcef5d555/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerUnitTest.java
[modify] https://crrev.com/f35338b71bcf13dad9e199f6fae519fbcef5d555/chrome/android/webapk/PRESUBMIT.py
[modify] https://crrev.com/f35338b71bcf13dad9e199f6fae519fbcef5d555/chrome/android/webapk/PRESUBMIT_test.py
[modify] https://crrev.com/f35338b71bcf13dad9e199f6fae519fbcef5d555/chrome/android/webapk/libs/client/BUILD.gn
[modify] https://crrev.com/f35338b71bcf13dad9e199f6fae519fbcef5d555/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVersion.template
[modify] https://crrev.com/f35338b71bcf13dad9e199f6fae519fbcef5d555/chrome/android/webapk/shell_apk/BUILD.gn
[add] https://crrev.com/f35338b71bcf13dad9e199f6fae519fbcef5d555/chrome/android/webapk/shell_apk/current_version/OWNERS
[add] https://crrev.com/f35338b71bcf13dad9e199f6fae519fbcef5d555/chrome/android/webapk/shell_apk/current_version/current_version.gni
[add] https://crrev.com/f35338b71bcf13dad9e199f6fae519fbcef5d555/chrome/android/webapk/shell_apk/request_update_for_version.gni
[delete] https://crrev.com/961f444839ecdfa01ba0822e2cc9f4aecff8d2ed/chrome/android/webapk/shell_apk/shell_apk_version.gni
►

Sign in to add a comment