New issue
Advanced search Search tips

Issue 884433 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Feature

Blocked on:
issue 861704



Sign in to add a comment

Add paymentMethodErrors, payerErrors, to PaymentDetailsUpdate

Project Member Reported by jinho.b...@samsung.com, Sep 15

Issue description

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21d6be9db21d7816382f376217a82419dc1fe9e5

commit 21d6be9db21d7816382f376217a82419dc1fe9e5
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Tue Dec 18 15:30:31 2018

PaymentRequest: Fix a bug that payer infos isn't updated

Before this patch, when user change selected payer info on payment
sheet UI, the payer info isn't updated on PayerDetailChange event.
It is because when OnPayerDetailChange is called, browser process passes
the cached payer info data in PaymentResponse to renderer process.
So, this patch changes to pass the current selected data instead of
cached data.

Test: chrome/browser/ui/views/payments/payment_request_payment_response_browsertest.cc

Bug: 884433
Change-Id: I61bfae37c97458a4fe162fe98817d161833d5649
Reviewed-on: https://chromium-review.googlesource.com/c/1378149
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617498}
[modify] https://crrev.com/21d6be9db21d7816382f376217a82419dc1fe9e5/chrome/browser/ui/views/payments/payment_request_payment_response_browsertest.cc
[modify] https://crrev.com/21d6be9db21d7816382f376217a82419dc1fe9e5/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/21d6be9db21d7816382f376217a82419dc1fe9e5/components/payments/content/payment_response_helper.cc
[modify] https://crrev.com/21d6be9db21d7816382f376217a82419dc1fe9e5/components/payments/content/payment_response_helper.h
[modify] https://crrev.com/21d6be9db21d7816382f376217a82419dc1fe9e5/components/test/data/payments/retry_with_payer_errors.js

Sign in to add a comment