New issue
Advanced search Search tips

Issue 884428 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Sep 25
Cc:
lucmult@chromium.org
michae...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

WebUI: Add PRESUBMIT to ensure the correct polymer.html file is imported.

Project Member Reported by dpa...@chromium.org, Sep 15 
When importing Polymer, the following file should always be used
chrome://resources/html/polymer.html

Instead of third_party's
chrome://resources/polymer/v1_0/polymer/polymer.html

The former properly configures Polymer to use native Shadow DOM (among other
settings). At [1], it was revealed (as part of the Polymer 2 migration) that some tests (and possibly prod code too?) were running with Shady DOM instead of Shadow DOM.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=875525#c15

Comment 1 by dbeam@chromium.org, Sep 15

Owner: dbeam@chromium.org
Status: Started (was: Available)
yoink
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aec80c237c1f99384c335debeae4161f9e1d27b8

commit aec80c237c1f99384c335debeae4161f9e1d27b8
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Sep 20 02:46:32 2018

Add presubmit to encourage folks to import the preconfigured polymer.html

R=dpapad@chromium.org
BUG= 884428 

Change-Id: Icfe2e0993204434e2639b506bd581e0fd7ef296e
Reviewed-on: https://chromium-review.googlesource.com/1227596
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592668}
[modify] https://crrev.com/aec80c237c1f99384c335debeae4161f9e1d27b8/tools/web_dev_style/html_checker.py
[modify] https://crrev.com/aec80c237c1f99384c335debeae4161f9e1d27b8/tools/web_dev_style/html_checker_test.py

Comment 3 by dbeam@chromium.org, Sep 25

Status: Fixed (was: Started)
►

Sign in to add a comment