New issue
Advanced search Search tips

Issue 884417 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

SmbService logs need to be stripped of file system id

Project Member Reported by baileyberro@chromium.org, Sep 14

Issue description

SmbService currently logs the FileSystemId which could include user info (the name of a file share on their network)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/139e8071e4b18774826fcdff293b45111691703b

commit 139e8071e4b18774826fcdff293b45111691703b
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Sep 17 20:14:49 2018

Remove FileSystemId from SmbService::Remount logs

This change removes logging the FileSystemId from the Remount flow.

Bug:  chromium:884417 
Change-Id: I3a8a3be4fa28d69f8d3c77ad4152de0a1ff60b54
Reviewed-on: https://chromium-review.googlesource.com/1227484
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591800}
[modify] https://crrev.com/139e8071e4b18774826fcdff293b45111691703b/chrome/browser/chromeos/smb_client/smb_service.cc

Labels: Merge-Request-70
Labels: OS-Chrome
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 18

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 25

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caeb0dba1bfca90f064786df344e84521f96a6d1

commit caeb0dba1bfca90f064786df344e84521f96a6d1
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Sep 25 22:51:03 2018

Remove FileSystemId from SmbService::Remount logs

This change removes logging the FileSystemId from the Remount flow.

Bug:  chromium:884417 
Change-Id: I3a8a3be4fa28d69f8d3c77ad4152de0a1ff60b54
Reviewed-on: https://chromium-review.googlesource.com/1227484
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591800}(cherry picked from commit 139e8071e4b18774826fcdff293b45111691703b)
Reviewed-on: https://chromium-review.googlesource.com/1244821
Cr-Commit-Position: refs/branch-heads/3538@{#673}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/caeb0dba1bfca90f064786df344e84521f96a6d1/chrome/browser/chromeos/smb_client/smb_service.cc

Status: Fixed (was: Started)

Sign in to add a comment