New issue
Advanced search Search tips

Issue 884415 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Wallpaper picker icon missing on low dpi devices

Project Member Reported by kaznacheev@chromium.org, Sep 14

Issue description

Chrome Version: 71.0.3552.0
OS: Chrome

What steps will reproduce the problem?
(0) Run ChromeOS on low dpi device (or VM or Linux build)
(1) Right-click on shelf or desktop, click on "Set wallpaper" menu item
(2) Wallpaper picker will open
(3) Observer the wallpaper picker icon in the shelf

What is the expected result?
Normal icon

What happens instead?
Default icon



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
This has been introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1219493. Apparently every icon referenced from a component extension's manifest needs to be mentioned in a .grd file as well.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86aec0d41357743de7dc37199cd3a1561a421f57

commit 86aec0d41357743de7dc37199cd3a1561a421f57
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Mon Sep 17 16:52:46 2018

Fix low res Wallpaper Picker icon

Add missing entry in the grd file.

Bug:  884415 
Test: manual
Change-Id: I18d4d48b1fb706be1f22f8a85ea4a54ac9cdaff5
Reviewed-on: https://chromium-review.googlesource.com/1225889
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591709}
[modify] https://crrev.com/86aec0d41357743de7dc37199cd3a1561a421f57/chrome/browser/resources/component_extension_resources.grd

Status: Fixed (was: Started)
Cc: wzang@chromium.org kaznacheev@chromium.org x...@chromium.org sgabr...@chromium.org ajha@chromium.org
 Issue 884666  has been merged into this issue.

Sign in to add a comment