New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task



Sign in to add a comment
link

Issue 884413: Fix chrome_public_test_apk on Oreo

Reported by bsheedy@chromium.org, Sep 14 Project Member

Issue description

The majority of tests instrumentation tests in chrome_public_test_apk run fine on Oreo devices. However, a handful fail:

org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferencesTest#testNavigationDeletion
org.chromium.chrome.browser.explore_sites.ExploreSitesBridgeTest#testGetIcon
org.chromium.chrome.browser.widget.PromoDialogTest#testBasic_HeaderBehavior_NoIllustration
org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferencesTest#testImportantSitesDialog
org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferencesTest#testClearingSiteDataClearsWebapps
org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferencesTest#testFrozenNavigationDeletion
org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferencesTest#testClearingEverything
org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferencesTest#testDialogAboutOtherFormsOfBrowsingHistory
org.chromium.webapk.shell_apk.DexLoaderTest#testLoadFromLocalDataDir
org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferencesTest#testClearingHistoryClearsWebappScopesAndLaunchTimes
org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferencesTest#testImportantSitesDialogNoFiltering

These should be fixed so that the experimental flag can be unset for the tests on O.

The majority seem to be under preferences.privacy, so assigning to that component.
 

Comment 1 by bsheedy@chromium.org, Sep 14

Sample failed build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Oreo%20Phone%20Tester/850

Looks like the privacy tests are consistently crashing for some reason.

Comment 2 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0183346307f959af42efec29b8ee773c15a8b00c

commit 0183346307f959af42efec29b8ee773c15a8b00c
Author: bsheedy <bsheedy@chromium.org>
Date: Fri Dec 07 01:05:57 2018

Disable standard instrumentation tests on O

chrome_public_test_apk and webview_instrumentation_test_apk have always
failed on O and end up burning a lot of device time with no one actively
monitoring them or trying to fix them. This combined with the few number
of devices that have Oreo means that the other tests that run on Oreo
that are monitored can end up not running due to capacity issues. So,
disable these tests on Oreo until they're either fixed or more capacity
is added.

Bug: 884413
Change-Id: Ica3a501ed078075dfb462f9cbcd7b3f26cb8dcad
Reviewed-on: https://chromium-review.googlesource.com/c/1366255
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614521}
[modify] https://crrev.com/0183346307f959af42efec29b8ee773c15a8b00c/testing/buildbot/chromium.android.json
[modify] https://crrev.com/0183346307f959af42efec29b8ee773c15a8b00c/testing/buildbot/test_suite_exceptions.pyl

Comment 3 by bugdroid, Jan 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3878c07b1c5501e27ea0964d8a0ba0196cf7680

commit f3878c07b1c5501e27ea0964d8a0ba0196cf7680
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Jan 30 08:08:56 2019

Fix ClearBrowsingDataPreferencesTest on O+

Changes the way that ClearBrowsingDataPreferencesTest disables the
automatic granting of notification permissions to the default search
engine.

Previously, it tried to manually set the permission to blocked,
which didn't work on O+ due to it automatically granting the permission
unconditionally as long as the GrantNotificationsToDSE feature was
enabled, causing a DCHECK to be hit due to attempting to change the
notification channel from allowed to blocked.

Instead, simply disable the feature that causes the DSE to get
notification permissions via the command line.

Also drive-by changes the EmbeddedTestServer usage to use the one
provided by the test rule that's automatically spun up and cleaned up
instead of trying to manage it manually within the test.

Bug: 884413
Change-Id: I23867c3374966a9cca4112d614a4710565717096
Reviewed-on: https://chromium-review.googlesource.com/c/1444755
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627349}
[modify] https://crrev.com/f3878c07b1c5501e27ea0964d8a0ba0196cf7680/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java

Comment 4 by bugdroid, Feb 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecf63b04590883d5124c7ff13e011598ee7a27e3

commit ecf63b04590883d5124c7ff13e011598ee7a27e3
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Feb 05 22:23:37 2019

Fix ExploreSitesBridgeExperimentalTest on O+

Fixes ExploreSitesBridgeExperimentalTest#testGetIcon which was failing
100% of the time on O+ due to a bug in Android's Bitmap.sameAs.

Also moves some asserts around so that failures in this test show up
properly as assertion errors instead of inducing a browser crash.

Bug: 927014, 884413
Change-Id: Iff6122932c4a1c4df32aa2104f14960908fd90e2
Reviewed-on: https://chromium-review.googlesource.com/c/1446831
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629336}
[modify] https://crrev.com/ecf63b04590883d5124c7ff13e011598ee7a27e3/chrome/android/javatests/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridgeExperimentalTest.java

Sign in to add a comment