New issue
Advanced search Search tips

Issue 884411 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Don't create a second TestContentClientInitializer in ScreenOrientationControllerTest

Project Member Reported by rmcelrath@chromium.org, Sep 14

Issue description

ScreenOrientationControllerTest (1) currently creates a WebviewTestHelper (2) object, which creates a new TestContentClientInitializer object. The test suite setup already creates a TestContentClientInitializer, but the fact that a second is being created means all initialization logic in TestContentClientInitalizer needs to be idempotent, which isn't ideal. This appears to be the only test that creates multiple TestContentClientInitializer objects.

1) https://cs.chromium.org/chromium/src/ui/views/test/webview_test_helper.h
2) https://cs.chromium.org/chromium/src/ash/content/display/screen_orientation_controller_chromeos_unittest.cc
 

Sign in to add a comment