New issue
Advanced search Search tips

Issue 884398 link

Starred by 7 users
Status: Started
Owner:
za...@chromium.org
Cc:
chirantan@chromium.org
smbar...@chromium.org
dgreid@chromium.org
za...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Crostini apps can't use virtio-wayland after chrome crashes

Project Member Reported by za...@chromium.org, Sep 14 
Because of the sandboxing for the crosvm virtio-wayland device, there is no access to the wayland socket after chrome crashes and restarts with a new socket.
Solution: bind mount the directory with the wayland socket, rather than the socket itself. This should provide a stable path for wayland sockets that resists chrome restarts while still being a tight sandbox for the wayland device.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/579bd2cf0e59c86779bc113734d583590341301c

commit 579bd2cf0e59c86779bc113734d583590341301c
Author: Zach Reizner <zachr@google.com>
Date: Tue Sep 18 04:35:02 2018

linux: bind wayland directory in virtio-wayland sandbox

For example, if the wayland socket is given as /run/wayland-0, the
entire /run/ directory will be bind mounted into the sandbox as
/wayland/. The wayland device will then be told to open the socket at
/wayland/wayland-0. If the /run/wayland-0 file is removed and a new
socket is opened in its place, as in a chrome crash, the
/wayland/wayland-0 socket will open the new socket rather than the one
belonging to the expire process.

TEST=vmc start termina; chrome://inducebrowsercrashforrealz;
    vsh termina; start wayland application
BUG=chromium:884398

Change-Id: I259eb2f7e29ee6b61836133ec1c3a110c5575957
Reviewed-on: https://chromium-review.googlesource.com/1227063
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/579bd2cf0e59c86779bc113734d583590341301c/src/linux.rs

Comment 2 by dverkamp@chromium.org, Jan 9

Cc: za...@chromium.org
 Issue 890628  has been merged into this issue.
►

Sign in to add a comment