New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 884390 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

Settings - Better Together is on is Green. It should be Google 900.

Project Member Reported by shibasheikh@chromium.org, Sep 14

Issue description

Make Better Together is on text Google 900. 
Screenshot attached.
 
Screenshot 2018-09-13 at 10.18.22 AM.png
749 KB View Download
Black :)
Cc: jordynass@chromium.org shibasheikh@chromium.org elizabethchiu@chromium.org
Labels: -Restrict-View-Google -M-70 M-71 OS-Chrome Pri-2 Type-Bug
Owner: shibasheikh@chromium.org
Status: Assigned (was: Unconfirmed)
Hey Shiba - is Google 900 just pure black, or is it a shade? Can you provide the RGB value please?
#202124 = Google Grey 900
Owner: jordynass@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ee2146359b024525f5f3bca50592a70817e90e8

commit 3ee2146359b024525f5f3bca50592a70817e90e8
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Tue Sep 18 02:25:18 2018

[CrOS MultiDevice]: Settings UI subpage aesthetic and string fixes

Changes in this CL:
  -Unindent 'forget device' line
  -Get rid of coloration of 'Better together is on'
  -When waiting for verification/server, show text for that instead of
'better together is on/off'
  -When waiting for verification/server, show and verify button instead
of suite toggle

Bug:  884390   870103 
Change-Id: I0c8fb9519d52c8a016f90eba32b26dda97bd449b
Reviewed-on: https://chromium-review.googlesource.com/1228935
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591919}
[modify] https://crrev.com/3ee2146359b024525f5f3bca50592a70817e90e8/chrome/browser/resources/settings/multidevice_page/multidevice_subpage.html
[modify] https://crrev.com/3ee2146359b024525f5f3bca50592a70817e90e8/chrome/browser/resources/settings/multidevice_page/multidevice_subpage.js

Status: Fixed (was: Assigned)

Sign in to add a comment