New issue
Advanced search Search tips

Issue 884389 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 874089



Sign in to add a comment

SingleProcessMash content_browsertests: TestTouchSelectionControllerClientAura::Wait() times out

Project Member Reported by xiy...@chromium.org, Sep 14

Issue description

TouchSelectionControllerClientAura probably not working as expected.

Relevant tests:
  TouchSelectionControllerClientAuraScaleFactorTest.*
  TouchSelectionControllerClientAuraTest.*


 
Blocking: 874089
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23066c81f4523280bf48e4c08fa47fe00e9648b1

commit 23066c81f4523280bf48e4c08fa47fe00e9648b1
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Tue Sep 25 19:15:41 2018

Enable more content_browsertests tests

After crrev.com/c/1233174, failures/time outs in the associated
bugs are gone. Enable more tests in single process mash.

Bug:  877496 ,  884389 ,  884393 
Change-Id: I35a96699fbee450e0522ff84267842e96fb7c29c
Reviewed-on: https://chromium-review.googlesource.com/1243194
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594046}
[modify] https://crrev.com/23066c81f4523280bf48e4c08fa47fe00e9648b1/testing/buildbot/filters/chromeos.single_process_mash.content_browsertests.filter

Status: Fixed (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/551fd2b31b0cabe30d587c4ea7e9a444a32d00db

commit 551fd2b31b0cabe30d587c4ea7e9a444a32d00db
Author: James Cook <jamescook@chromium.org>
Date: Wed Sep 26 00:43:59 2018

Revert "Enable more content_browsertests tests"

This reverts commit 23066c81f4523280bf48e4c08fa47fe00e9648b1.

Reason for revert:
Causing single_process_mash_content_browsertests failures on
a variety of chromeos bots:
https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29176
https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8015

Original change's description:
> Enable more content_browsertests tests
> 
> After crrev.com/c/1233174, failures/time outs in the associated
> bugs are gone. Enable more tests in single process mash.
> 
> Bug:  877496 ,  884389 ,  884393 
> Change-Id: I35a96699fbee450e0522ff84267842e96fb7c29c
> Reviewed-on: https://chromium-review.googlesource.com/1243194
> Reviewed-by: James Cook <jamescook@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594046}

TBR=jamescook@chromium.org,xiyuan@chromium.org

Change-Id: Iabbeba969d49ef6046bf0747dd51c917ad0d1445
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  877496 ,  884389 ,  884393 
Reviewed-on: https://chromium-review.googlesource.com/1244661
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594164}
[modify] https://crrev.com/551fd2b31b0cabe30d587c4ea7e9a444a32d00db/testing/buildbot/filters/chromeos.single_process_mash.content_browsertests.filter

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6dce47de0b114bef9e82572308a4d63c619321c

commit d6dce47de0b114bef9e82572308a4d63c619321c
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Wed Sep 26 19:30:44 2018

Reland "Enable more content_browsertests tests"

This is a reland of 23066c81f4523280bf48e4c08fa47fe00e9648b1

Original change's description:
> Enable more content_browsertests tests
>
> After crrev.com/c/1233174, failures/time outs in the associated
> bugs are gone. Enable more tests in single process mash.
>
> Bug:  877496 ,  884389 ,  884393 
> Change-Id: I35a96699fbee450e0522ff84267842e96fb7c29c
> Reviewed-on: https://chromium-review.googlesource.com/1243194
> Reviewed-by: James Cook <jamescook@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594046}

Bug:  877496 ,  884389 ,  884393 
Change-Id: If452611db11c3b5e6f92e66e9a1f6890acac52f7
Reviewed-on: https://chromium-review.googlesource.com/1246152
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594430}
[modify] https://crrev.com/d6dce47de0b114bef9e82572308a4d63c619321c/testing/buildbot/filters/chromeos.single_process_mash.content_browsertests.filter

Sign in to add a comment