Oops, the issue I duped to was actually for a slightly different notification.

The issue described is not intended. This may be related to Jordy's recent CL https://chromium-review.googlesource.com/c/chromium/src/+/1205495.

I will take this in addition to taking  crbug.com/883069  (they're pretty similar)

 Issue 881549  has been merged into this issue.

I misunderstood this issue. It involves some setup logic I'm not completely familiar with. However, Jordy, it looks like you had a really good understanding of what was necessary here -- you filed  crbug.com/881549  which seems to get at the solution we'd want for this bug. Jordy, do you have the bandwidth to take this issue? If not, can you describe what needs to be done?

Yeah, I can take this on.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/971180fc6c175baa4d6b40fda809fe3a81191111

commit 971180fc6c175baa4d6b40fda809fe3a81191111
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Tue Oct 09 19:04:55 2018

[CrOS MultiDevice] Make SetupCompletionRecorder record its own events

In order to ensure that the 'new host' and 'Chromebook added'
notifications to get new users to set up multidevice features and to
inform them that their current device is connected respectively are
providing correct and useful information, we need to record when the
user completes setup and when they receive an update that their host
phone as been verified. The former behavior was implemented in an
earlier CL. This CL implements the latter and observes
HostStatusProvider to keep track of both timestamps.

-----

MANUAL TEST

Completion and verification of pref recording in chronos log output:

localhost ~ # cat /home/chronos/user/log/chrome | grep -e SetupFlowCompletionRecorderImpl
[13763:13763:1008/180345.702849:INFO:setup_flow_completion_recorder_impl.cc(105)] SetupFlowCompletionRecorderImpl::OnHostStatusChange(): Setup flow successfully completed. Recording timestamp 1539047025702.
[13763:13763:1008/180346.310752:INFO:setup_flow_completion_recorder_impl.cc(115)] SetupFlowCompletionRecorderImpl::OnHostStatusChange(): New host verified. Recording timestamp 1539047026310.



Bug:  892829 ,  884373 
Change-Id: I81faae473d5c784f54cb122df37d68856fb6a27f
Reviewed-on: https://chromium-review.googlesource.com/c/1270004
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598022}
[modify] https://crrev.com/971180fc6c175baa4d6b40fda809fe3a81191111/chromeos/services/multidevice_setup/BUILD.gn
[modify] https://crrev.com/971180fc6c175baa4d6b40fda809fe3a81191111/chromeos/services/multidevice_setup/account_status_change_delegate_notifier_impl.cc
[modify] https://crrev.com/971180fc6c175baa4d6b40fda809fe3a81191111/chromeos/services/multidevice_setup/account_status_change_delegate_notifier_impl.h
[modify] https://crrev.com/971180fc6c175baa4d6b40fda809fe3a81191111/chromeos/services/multidevice_setup/account_status_change_delegate_notifier_impl_unittest.cc
[add] https://crrev.com/971180fc6c175baa4d6b40fda809fe3a81191111/chromeos/services/multidevice_setup/fake_host_device_timestamp_manager.cc
[add] https://crrev.com/971180fc6c175baa4d6b40fda809fe3a81191111/chromeos/services/multidevice_setup/fake_host_device_timestamp_manager.h
[delete] https://crrev.com/b75ef9be7f158f67a17b52b2d79f6a7877ede0a1/chromeos/services/multidevice_setup/fake_setup_flow_completion_recorder.cc
[delete] https://crrev.com/b75ef9be7f158f67a17b52b2d79f6a7877ede0a1/chromeos/services/multidevice_setup/fake_setup_flow_completion_recorder.h
[add] https://crrev.com/971180fc6c175baa4d6b40fda809fe3a81191111/chromeos/services/multidevice_setup/host_device_timestamp_manager.h
[add] https://crrev.com/971180fc6c175baa4d6b40fda809fe3a81191111/chromeos/services/multidevice_setup/host_device_timestamp_manager_impl.cc
[add] https://crrev.com/971180fc6c175baa4d6b40fda809fe3a81191111/chromeos/services/multidevice_setup/host_device_timestamp_manager_impl.h
[add] https://crrev.com/971180fc6c175baa4d6b40fda809fe3a81191111/chromeos/services/multidevice_setup/host_device_timestamp_manager_impl_unittest.cc
[modify] https://crrev.com/971180fc6c175baa4d6b40fda809fe3a81191111/chromeos/services/multidevice_setup/multidevice_setup_impl.cc
[modify] https://crrev.com/971180fc6c175baa4d6b40fda809fe3a81191111/chromeos/services/multidevice_setup/multidevice_setup_impl.h
[modify] https://crrev.com/971180fc6c175baa4d6b40fda809fe3a81191111/chromeos/services/multidevice_setup/multidevice_setup_impl_unittest.cc
[modify] https://crrev.com/971180fc6c175baa4d6b40fda809fe3a81191111/chromeos/services/multidevice_setup/multidevice_setup_service.cc
[delete] https://crrev.com/b75ef9be7f158f67a17b52b2d79f6a7877ede0a1/chromeos/services/multidevice_setup/setup_flow_completion_recorder.h
[delete] https://crrev.com/b75ef9be7f158f67a17b52b2d79f6a7877ede0a1/chromeos/services/multidevice_setup/setup_flow_completion_recorder_impl.cc
[delete] https://crrev.com/b75ef9be7f158f67a17b52b2d79f6a7877ede0a1/chromeos/services/multidevice_setup/setup_flow_completion_recorder_impl.h
[delete] https://crrev.com/b75ef9be7f158f67a17b52b2d79f6a7877ede0a1/chromeos/services/multidevice_setup/setup_flow_completion_recorder_impl_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c2d9c027d9ea879fdecf4dbd5f09aee7437e264

commit 9c2d9c027d9ea879fdecf4dbd5f09aee7437e264
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Thu Oct 11 04:07:43 2018

[CrOS MultiDevice] Prevent Chromebook added event right after setup

The logic that decides when to show MultiDevice notification has no way
of discriminating between a host set on the Chromebook in use and a
host set on a different Chromebook. Therefore, whenever a user finishes
setup flow and receives verification, they see a spammy notification
that they have a host on the account even though they just set it there.

This CL adds a pref to record when the Chromebook finished setup flow
and when the account no longer has a set host. This way, when
determining whether to show the 'Chromebook added' event, the
AccountStatusChangeDelegateNotifierImpl can check whether the verified
host was set on the Chromebook and, if it was, not send the spammy
notification.

Bug:  884373 
Change-Id: I51d1a92515e5e1fcc226422efd5856a43535159b
Reviewed-on: https://chromium-review.googlesource.com/c/1275128
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598665}
[modify] https://crrev.com/9c2d9c027d9ea879fdecf4dbd5f09aee7437e264/chromeos/services/multidevice_setup/account_status_change_delegate_notifier_impl.cc
[modify] https://crrev.com/9c2d9c027d9ea879fdecf4dbd5f09aee7437e264/chromeos/services/multidevice_setup/account_status_change_delegate_notifier_impl_unittest.cc
[modify] https://crrev.com/9c2d9c027d9ea879fdecf4dbd5f09aee7437e264/chromeos/services/multidevice_setup/fake_host_device_timestamp_manager.cc
[modify] https://crrev.com/9c2d9c027d9ea879fdecf4dbd5f09aee7437e264/chromeos/services/multidevice_setup/fake_host_device_timestamp_manager.h
[modify] https://crrev.com/9c2d9c027d9ea879fdecf4dbd5f09aee7437e264/chromeos/services/multidevice_setup/host_device_timestamp_manager.h
[modify] https://crrev.com/9c2d9c027d9ea879fdecf4dbd5f09aee7437e264/chromeos/services/multidevice_setup/host_device_timestamp_manager_impl.cc
[modify] https://crrev.com/9c2d9c027d9ea879fdecf4dbd5f09aee7437e264/chromeos/services/multidevice_setup/host_device_timestamp_manager_impl.h
[modify] https://crrev.com/9c2d9c027d9ea879fdecf4dbd5f09aee7437e264/chromeos/services/multidevice_setup/host_device_timestamp_manager_impl_unittest.cc

Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The CLs were both landed before the branch was cut, so no merge is needed.

See https://chromium.googlesource.com/chromium/src.git/+log/refs/branch-heads/3578.

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot