Project: chromium/src
Branch: master

commit 09d9d17ad881285e2520d788bda2be676da15be8
Author: Caleb Rouleau <crouleau@chromium.org>
Date:   Fri Sep 14 22:08:54 2018

    [ChromeDriver] Set screenshot timeout to 10 seconds.
    
    It is currently set to 10 minutes, which means that test suites
    will time out first so we don't get a chance to provide a useful error
    message. It also makes reproing issues difficult because you need
    to wait for 10 minutes for them.
    
    Note that because of various retries, this could amount to 60 seconds
    of total time because of 2 ChromeDriver retries * 3 higher level retries.
    
    Bug: b/115528744
    Change-Id: I15753fd5ac27e5d5ec36aa4f81a1a80133f4d6ff
    Reviewed-on: https://chromium-review.googlesource.com/1227307
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#591493}

M       chrome/test/chromedriver/chrome/web_view_impl.cc

https://chromium-review.googlesource.com/1227307

Requesting merge for https://chromium-review.googlesource.com/c/chromium/src/+/1227476 for M70

This work was originally done in https://b.corp.google.com/issues/115528744#comment19

Note that this change is in Chromedriver directory (src/chrome/test/chromedriver), and Chrome does not depend on that at all, so this will have no impact on Chrome binary that is shipping. see go/chromedriver-versioning and go/chops-proj-rev-27 for background.

This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Can you please mark which OS's this is impacting?

Note that this change is in Chromedriver directory (src/chrome/test/chromedriver), and Chrome does not depend on that at all, so this will have no impact on Chrome binary that is shipping. see go/chromedriver-versioning and go/chops-proj-rev-27 for background.

Approved - branch:3538

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f30783735126b32a33768dec25a72e1e7a8186d

commit 9f30783735126b32a33768dec25a72e1e7a8186d
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Mon Sep 17 22:36:00 2018

[ChromeDriver] Set screenshot timeout to 10 seconds.

It is currently set to 10 minutes, which means that test suites
will time out first so we don't get a chance to provide a useful error
message. It also makes reproing issues difficult because you need
to wait for 10 minutes for them.

Note that because of various retries, this could amount to 60 seconds
of total time because of 2 ChromeDriver retries * 3 higher level retries.

Bug:  884362 
Change-Id: I15753fd5ac27e5d5ec36aa4f81a1a80133f4d6ff
Reviewed-on: https://chromium-review.googlesource.com/1227307
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591493}(cherry picked from commit 09d9d17ad881285e2520d788bda2be676da15be8)
Reviewed-on: https://chromium-review.googlesource.com/1227476
Cr-Commit-Position: refs/branch-heads/3538@{#466}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/9f30783735126b32a33768dec25a72e1e7a8186d/chrome/test/chromedriver/chrome/web_view_impl.cc