New issue
Advanced search Search tips

Issue 884354 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Add UMAs for ConnectivityDetector used by offline indicator

Project Member Reported by jianli@chromium.org, Sep 14

Issue description

We need to add some UMAs for ConnectivityDetector.
 
Labels: Merge-Rejected-70
Verified in 71.0.3556.0
Labels: -Merge-Rejected-70 Merge-Request-70
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 20

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-70 Merge-Approved-70
Approved for merge to 70, branch 3538.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 20

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52b0d058008235fcb3d8c7d21ea9264b4dcd4782

commit 52b0d058008235fcb3d8c7d21ea9264b4dcd4782
Author: Jian Li <jianli@chromium.org>
Date: Thu Sep 20 17:27:59 2018

Merge M70: Add some UMAs for connectivity detector used by offline indicator

TBR=jianli@chromium.org

(cherry picked from commit 4939619f52c6830aee10062de29ad3faa3a6ed65)

Bug:  884354 
Change-Id: I803bf529d1d87529ff4059552a0bef8c5f8dbcf6
Reviewed-on: https://chromium-review.googlesource.com/1227402
Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591791}
Reviewed-on: https://chromium-review.googlesource.com/1236464
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#545}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/52b0d058008235fcb3d8c7d21ea9264b4dcd4782/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/ConnectivityDetector.java
[modify] https://crrev.com/52b0d058008235fcb3d8c7d21ea9264b4dcd4782/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/ConnectivityDetectorTest.java
[modify] https://crrev.com/52b0d058008235fcb3d8c7d21ea9264b4dcd4782/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/52b0d058008235fcb3d8c7d21ea9264b4dcd4782/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Labels: Merge-Merged-70-refsbranch-heads3538
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52b0d058008235fcb3d8c7d21ea9264b4dcd4782
Commit: 52b0d058008235fcb3d8c7d21ea9264b4dcd4782
Author: jianli@chromium.org
Commiter: jianli@chromium.org
Date: 2018-09-20 17:27:59 +0000 UTC
Merge M70: Add some UMAs for connectivity detector used by offline indicator

TBR=jianli@chromium.org

(cherry picked from commit 4939619f52c6830aee10062de29ad3faa3a6ed65)

Bug:  884354 
Change-Id: I803bf529d1d87529ff4059552a0bef8c5f8dbcf6
Reviewed-on: https://chromium-review.googlesource.com/1227402
Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591791}
Reviewed-on: https://chromium-review.googlesource.com/1236464
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#545}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}

Sign in to add a comment