Issue metadata
Sign in to add a comment
|
20.2%-31% regression in rendering.desktop at 591089:591145 |
||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 14
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15f0efa5640000
,
Sep 16
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/15f0efa5640000 Propagate window positions down OOPIF chains by kenrb@chromium.org https://chromium.googlesource.com/chromium/src/+/ee24be2aa0c578cf371f64dea1b887635959c833 258.7 → 336.5 (+77.82) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/rendering-benchmarks
,
Oct 16
Sorry for taking so long in having a look at this. Is it certain that my CL caused that perf regression? It was fixing a functional regression that was causing <select> element menus to sometimes appear in the wrong position. This could potentially cause more IPC messages to OOPIFs while a top-level page is scrolling, but that is hard to avoid while still be correct.
,
Oct 16
The graphs have moved after this regression... one way to find out is to do a test CL that undoes the propagation and run a pinpoint job using the appropriate https://chromium.googlesource.com URL. If this fixes a bug and the regression is deemed acceptable (not sure if this CL was blamed to other regressions or not) then feel free to WontFix. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Sep 14