New issue
Advanced search Search tips

Issue 884328 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.5% regression in rendering.mobile at 590877:590905

Project Member Reported by npm@chromium.org, Sep 14

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=884328

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=62d2724966365e1f9dee798a268332eee97f471aa5a20bb58caca8ed783c8dd9


Bot(s) for this bug's original alert(s):

Android Nexus5 Perf

rendering.mobile - Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Cc: danakj@chromium.org
Owner: danakj@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1742b7a5640000

Comment and clean up code for marking layers to PushPropertiesTo. by danakj@chromium.org
https://chromium.googlesource.com/chromium/src/+/956d1c82d6e8263fecbd7d2240774a7363aea2c4
0.3888 → 0.4192 (+0.03035)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Cc: sunn...@chromium.org
This is interesting, I think looking at the other metrics and traces the impl thread times have improved and FPS increased.  We're tickling what looks like an issue with how we limit PrepareTiles.

We're running slightly more PrepareTiles per-frame on average.  It's happening because the sample is still below 60Hz, and depending on how BeginFrames align, we sometimes get two PrepareTiles per Draw.


Sunny mentioned that moving the PrepareTiles throttling count to reset on Draw instead of on BeginFrame would remove the general issue.

Sign in to add a comment