Properly fix lint errors for module titles not being referenced |
||
Issue descriptionDynamic feature module titles need to live in the base module and be referenced in the feature module. That means the title is not referenced in the base module leading to lint errors. Currently, we work around this by dummy referencing the title in the base module. Find a better workaround.
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2b7ecbbfe7e65a2963e078069bbc44339a5ebc8 commit d2b7ecbbfe7e65a2963e078069bbc44339a5ebc8 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Wed Jan 16 01:25:16 2019 [ar/vr] Finalize module title strings TBR=mthiesse@chromium.org Bug: 863064, 884321 Change-Id: I490f9f252c1a378067c72420562a178ae54b6d79 Reviewed-on: https://chromium-review.googlesource.com/c/1409817 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#622971} [modify] https://crrev.com/d2b7ecbbfe7e65a2963e078069bbc44339a5ebc8/chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreJavaUtils.java [modify] https://crrev.com/d2b7ecbbfe7e65a2963e078069bbc44339a5ebc8/chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java [modify] https://crrev.com/d2b7ecbbfe7e65a2963e078069bbc44339a5ebc8/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java [modify] https://crrev.com/d2b7ecbbfe7e65a2963e078069bbc44339a5ebc8/chrome/android/java/strings/android_chrome_strings.grd
,
Jan 16
(6 days ago)
Fixed by referencing the module title in the install UI. |
||
►
Sign in to add a comment |
||
Comment 1 by tiborg@chromium.org
, Jan 3