Include net_unittests on CQ and waterfall runs on Fuchsia |
||||
Issue descriptionnet_unittests is a large and important test suite that we should be running on the main waterfall (it's currently only on fyi), esp. since Fuchsia-the-team is using net via cronet as their network stack. wez thought the main blocker was performance, rather than flakiness at this point. jbudorick, are you able to estimate if we would have capacity to add this suite on Fuchsia now with it sharded N ways for some larger N? Searching here for [fuchsia net_unittests] there are some outstanding bugs that we would want to investigate, but not a huge number of tests, so disabling those and getting the vast majority of the rest of the suite on the waterfall would be a win.
,
Nov 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f130981cbd9032229906a0171bb87aa2c6fe2abb commit f130981cbd9032229906a0171bb87aa2c6fe2abb Author: Wez <wez@chromium.org> Date: Sat Nov 03 05:42:24 2018 Add FDIO_EVT_PEER_CLOSED to WatchFileDescriptor(WATCH_READ) events. WatchFileDescriptor(WATCH_READ) should result in OnFileCanReadWithoutBlocking() if the descriptor is at end-of-stream when it is invoked, to wake the caller to detect that by attempting to read and receiving zero bytes. Bug: 898938 , 706592, 884299 Change-Id: I77662fe77eb8fb988089640a75a60d470770b78f Reviewed-on: https://chromium-review.googlesource.com/c/1316672 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605154} [modify] https://crrev.com/f130981cbd9032229906a0171bb87aa2c6fe2abb/base/message_loop/message_pump_fuchsia.cc
,
Nov 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/088e95617862c91da15e97a233e59811b798a95f commit 088e95617862c91da15e97a233e59811b798a95f Author: Wez <wez@chromium.org> Date: Sat Nov 03 06:08:28 2018 Revert "Add FDIO_EVT_PEER_CLOSED to WatchFileDescriptor(WATCH_READ) events." This reverts commit f130981cbd9032229906a0171bb87aa2c6fe2abb. Reason for revert: Doesn't actually fix anything. >.< Original change's description: > Add FDIO_EVT_PEER_CLOSED to WatchFileDescriptor(WATCH_READ) events. > > WatchFileDescriptor(WATCH_READ) should result in > OnFileCanReadWithoutBlocking() if the descriptor is at end-of-stream > when it is invoked, to wake the caller to detect that by attempting to > read and receiving zero bytes. > > Bug: 898938 , 706592, 884299 > Change-Id: I77662fe77eb8fb988089640a75a60d470770b78f > Reviewed-on: https://chromium-review.googlesource.com/c/1316672 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605154} TBR=wez@chromium.org,sergeyu@chromium.org,fdegans@chromium.org Change-Id: I1a98ece4b90de54c2c789dee64c226eb92bcda38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898938 , 706592, 884299 Reviewed-on: https://chromium-review.googlesource.com/c/1316675 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#605157} [modify] https://crrev.com/088e95617862c91da15e97a233e59811b798a95f/base/message_loop/message_pump_fuchsia.cc
,
Dec 20
,
Dec 20
,
Jan 3
,
Jan 3
With some fixes before vacation, we have managed to get net_unittests to be stable on Fuchsia. Looking into enabling the test suite on the main waterfall.
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1541ca0168d7443878755b5ae9ec57f3feadb04 commit a1541ca0168d7443878755b5ae9ec57f3feadb04 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Jan 09 20:05:46 2019 [Fuchsia] Enable net_unittests on the main waterfall. In the past 2 weeks, the suite has only flaked on a single test, which is being investigated. Bug: 847915 , 877248, 884299 Change-Id: Ieb0cf0184b59d397a29c41ab079ecb048b409af2 Reviewed-on: https://chromium-review.googlesource.com/c/1394938 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#621282} [modify] https://crrev.com/a1541ca0168d7443878755b5ae9ec57f3feadb04/testing/buildbot/chromium.linux.json [modify] https://crrev.com/a1541ca0168d7443878755b5ae9ec57f3feadb04/testing/buildbot/test_suite_exceptions.pyl |
||||
►
Sign in to add a comment |
||||
Comment 1 by w...@chromium.org
, Sep 14