Now that I understand the features of JavaScript 6, I think it would be beneficial to migrate the SwitchAccess code to use the new features.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbabf91f1975eab187797ce752eb8ca59ecc3143 commit bbabf91f1975eab187797ce752eb8ca59ecc3143 Author: Zach Helfinstein <zhelfins@chromium.org> Date: Mon Sep 17 22:18:40 2018 Update SwitchAccess commands.js to use ES2015 Bug: 884297 Change-Id: I379bc86df9749ff08797fe2034f9d4718961075e Reviewed-on: https://chromium-review.googlesource.com/1227598 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#591839} [modify] https://crrev.com/bbabf91f1975eab187797ce752eb8ca59ecc3143/chrome/browser/resources/chromeos/switch_access/commands.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40810976b4c40a0e01530214418ed2d0783ac2a3 commit 40810976b4c40a0e01530214418ed2d0783ac2a3 Author: Zach Helfinstein <zhelfins@chromium.org> Date: Tue Sep 18 21:03:20 2018 Update SwitchAccess automation_manager.js to ES2015 Bug: 884297 Change-Id: I268e11dc5c71a78208fb07afd8dcc86c26964c05 Reviewed-on: https://chromium-review.googlesource.com/1229773 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#592187} [modify] https://crrev.com/40810976b4c40a0e01530214418ed2d0783ac2a3/chrome/browser/resources/chromeos/switch_access/automation_manager.js [modify] https://crrev.com/40810976b4c40a0e01530214418ed2d0783ac2a3/chrome/browser/resources/chromeos/switch_access/context_menu_manager.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2f8769652ff111dc1b8ec76b31eb7655de2752c commit d2f8769652ff111dc1b8ec76b31eb7655de2752c Author: Zach Helfinstein <zhelfins@chromium.org> Date: Wed Sep 19 19:48:31 2018 Update SwitchAccess auto_scan_manager.js to ES2015 Bug: 884297 Change-Id: I4d733650e54b01459154c1c59da5c95246ec3d05 Reviewed-on: https://chromium-review.googlesource.com/1232682 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592523} [modify] https://crrev.com/d2f8769652ff111dc1b8ec76b31eb7655de2752c/chrome/browser/resources/chromeos/switch_access/auto_scan_manager.js [modify] https://crrev.com/d2f8769652ff111dc1b8ec76b31eb7655de2752c/chrome/browser/resources/chromeos/switch_access/automation_manager.js [modify] https://crrev.com/d2f8769652ff111dc1b8ec76b31eb7655de2752c/chrome/browser/resources/chromeos/switch_access/commands.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48df727c4efef6e4fd1d40302846f507e83969b9 commit 48df727c4efef6e4fd1d40302846f507e83969b9 Author: Zach Helfinstein <zhelfins@chromium.org> Date: Fri Sep 21 18:34:32 2018 Update the rest of SwitchAccess to ES2015 Bug: 884297 Change-Id: Iff20201277983eed3d851279ed6e7042ae17d250 Reviewed-on: https://chromium-review.googlesource.com/1237554 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#593271} [modify] https://crrev.com/48df727c4efef6e4fd1d40302846f507e83969b9/chrome/browser/resources/chromeos/switch_access/context_menu_manager.js [modify] https://crrev.com/48df727c4efef6e4fd1d40302846f507e83969b9/chrome/browser/resources/chromeos/switch_access/keyboard_handler.js [modify] https://crrev.com/48df727c4efef6e4fd1d40302846f507e83969b9/chrome/browser/resources/chromeos/switch_access/message_handler.js [modify] https://crrev.com/48df727c4efef6e4fd1d40302846f507e83969b9/chrome/browser/resources/chromeos/switch_access/options.js [modify] https://crrev.com/48df727c4efef6e4fd1d40302846f507e83969b9/chrome/browser/resources/chromeos/switch_access/prefs.js [modify] https://crrev.com/48df727c4efef6e4fd1d40302846f507e83969b9/chrome/browser/resources/chromeos/switch_access/switch_access.js [modify] https://crrev.com/48df727c4efef6e4fd1d40302846f507e83969b9/chrome/browser/resources/chromeos/switch_access/switch_access_interface.js [modify] https://crrev.com/48df727c4efef6e4fd1d40302846f507e83969b9/chrome/browser/resources/chromeos/switch_access/switch_access_predicate.js [modify] https://crrev.com/48df727c4efef6e4fd1d40302846f507e83969b9/chrome/browser/resources/chromeos/switch_access/test_support.js
Comment 1 by bugdroid1@chromium.org
, Sep 17