Observation video: https://storage.cloud.google.com/chromiumos-test-logs/bugfiles/cr/884284/crostini-issue-while-offline.webm?_ga=2.11334707.-66391737.1524518032

@nverne could we wait to set the preference until termina is installed?

And do you know why uninstall fails? Shouldn't it just be unsetting the preference?

Uninstall does much more than just unsetting the preference. It deletes the VM disk (and the container with it), then it uninstalls the Termina component.

I meant in this case it's just unsetting the preference, since the device was offline during setup and couldn't download termina or the container. Or is there more that happens even when offline?

I have a WIP CL for this at: https://chromium-review.googlesource.com/c/chromium/src/+/1233016

It side steps some of the current uninstall flow which expects the VM & component to exist. This flow also removes/uninstalls the VM, component, the crostini manager settings, application info and mime type info.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da5b445c45466936dea5c5b2331ed23773d2f62a

commit da5b445c45466936dea5c5b2331ed23773d2f62a
Author: Josh Pratt <jopra@chromium.org>
Date: Tue Sep 25 01:00:38 2018

Skip VM uninstallation steps if Crostini was not fully installed.

This CL skips parts of the uninstall flow if the Termina VM was not
installed. This occurs if installation and uninstallation occurs
offline.

BUG= 884284 

Change-Id: I7e669605844b0914948bde792f67891e55ad0e7a
Reviewed-on: https://chromium-review.googlesource.com/1233016
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Josh Pratt <jopra@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593787}
[modify] https://crrev.com/da5b445c45466936dea5c5b2331ed23773d2f62a/chrome/browser/chromeos/crostini/crostini_remover.cc
[modify] https://crrev.com/da5b445c45466936dea5c5b2331ed23773d2f62a/chrome/browser/ui/views/crostini/crostini_browser_test_util.cc
[modify] https://crrev.com/da5b445c45466936dea5c5b2331ed23773d2f62a/chrome/browser/ui/views/crostini/crostini_browser_test_util.h
[modify] https://crrev.com/da5b445c45466936dea5c5b2331ed23773d2f62a/chrome/browser/ui/views/crostini/crostini_uninstaller_view_browsertest.cc

This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Leaving as started until merged into M70.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e311674ee32761c83d717c88aa400fcfa2a3994

commit 7e311674ee32761c83d717c88aa400fcfa2a3994
Author: Nicholas Verne <nverne@chromium.org>
Date: Fri Sep 28 04:54:02 2018

Merge into M70

Skip VM uninstallation steps if Crostini was not fully installed.

This CL skips parts of the uninstall flow if the Termina VM was not
installed. This occurs if installation and uninstallation occurs
offline.

BUG= 884284 

Change-Id: I0586df4871cc436b9d51d37733b112e6a9276e57
Reviewed-on: https://chromium-review.googlesource.com/1250387
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#728}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/7e311674ee32761c83d717c88aa400fcfa2a3994/chrome/browser/chromeos/crostini/crostini_remover.cc
[modify] https://crrev.com/7e311674ee32761c83d717c88aa400fcfa2a3994/chrome/browser/ui/views/crostini/crostini_browser_test_util.cc
[modify] https://crrev.com/7e311674ee32761c83d717c88aa400fcfa2a3994/chrome/browser/ui/views/crostini/crostini_browser_test_util.h
[modify] https://crrev.com/7e311674ee32761c83d717c88aa400fcfa2a3994/chrome/browser/ui/views/crostini/crostini_uninstaller_view_browsertest.cc

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/7e311674ee32761c83d717c88aa400fcfa2a3994

Commit: 7e311674ee32761c83d717c88aa400fcfa2a3994
Author: nverne@chromium.org
Commiter: nverne@chromium.org
Date: 2018-09-28 04:54:02 +0000 UTC

Merge into M70

Skip VM uninstallation steps if Crostini was not fully installed.

This CL skips parts of the uninstall flow if the Termina VM was not
installed. This occurs if installation and uninstallation occurs
offline.

BUG= 884284 

Change-Id: I0586df4871cc436b9d51d37733b112e6a9276e57
Reviewed-on: https://chromium-review.googlesource.com/1250387
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#728}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}

CL was merged into m70, should be fixed.

So I got some mix results:

M70 (70.0.3538.124.0, chrome os: 11021.104.0, stable): Deletion of linux with wifi disabled is still a no-op (kevin board)

M71 (71.0.3578.119, chrome os: 11151.97.0, stable): Deletion of linux with wifi disabled is still a no-op (kevin board)

M72 (72,0,3626.43, chrome os: 11316.57.0, beta): Deletion of linux with wifi disabled works appropriately. Create linux with wifi enable work fine

M73 (73.0.3654.0, chrome os: 11516.0.0, dev): Deletion of linux with wifi disabled works appropriately. Create linux with wifi enable work fine (eve board)

Closing the issue as it is working in M72. (M71 and M70 were already out with stable release).