New issue
Advanced search Search tips

Issue 884278 link

Starred by 1 user
Status: WontFix
Owner:
agrieve@chromium.org
Closed: Oct 3
Cc:
dtrainor@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

22.5kb regression in resource_sizes (MonochromePublic.apk) at 591362:591362

Project Member Reported by agrieve@chromium.org, Sep 14 
Caused by “Add a styleable circular progress bar for DHv2”

Commit: 20ae78ee8037011f8aeff7efab426c24c7c7132a

Link to size graph: https://chromeperf.appspot.com/report?sid=bb23072657e2d7ca892a1c3fa4643b1ee29b3a0a44d0732adda87168e89c0380&num_points=10&rev=591362

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on the trybot result (https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-binary-size/54818):

InstallBreakdown (+36,012.64 bytes):
        +4,573 bytes Non-compiled Android resources size
          +898 bytes Package metadata size
    +26,761.64 bytes Java code size
        +3,780 bytes Compiled Android resources size


Biggest symbol in the supersize diff is one that I don't think should be there:
+ 0)       3787 (23.2%) m@0x0        3787 (0->3787)     $root_gen_dir/chrome/android/chrome_download_java_resources.srcjar/org/chromium/chrome/download/R.java
               R$styleable#<clinit>

R.java files that are not used by webview should be fully optimized away by proguard. 
Nothing out stood out to me in terms of size though (it adds drawables and code).
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Sep 14 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=884278

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1589ad03e79b310475e3fded5f6ddfd1f816f78f2ca722b60758c7cef85db9c4


Bot(s) for this bug's original alert(s):

Android Builder Perf
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Sep 14

Owner: dtrainor@chromium.org
Assigning to dtrainor@chromium.org because this is the only CL in range:
Add a styleable circular progress bar for DHv2

Add a new CircularProgressView to be used in various places in downloads
home.  This currently supports styling and the initial small/large
progress bar style buttons that we need.

BUG=868554

Change-Id: I68aaea3984e5cd3ff62b1ec6a298a409f5d00b08
Reviewed-on: https://chromium-review.googlesource.com/1220177
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591362}

Comment 3 by dtrainor@chromium.org, Sep 17 

Hmm it looks like it's yelling about styleable attributes?  Do those balloon code more than expected?

I can try taking those out and investigating.

Comment 4 by agrieve@chromium.org, Sep 18

Owner: agrieve@chromium.org
R.java files should only take up size if they are also used by webview, which I don't think should be the case for this change since it's under //chrome.

Looks like proguard isn't removing a method that it should be removing.

We should first see if this is a problem downstream, and if so, use -whyareyoukeeping to figure out why.

I can take care of this (I had assigned it to myself, but looks like a bot set it to you in #2)

Comment 5 by dtrainor@chromium.org, Sep 18 

Thanks Andrew!  Let me know if I end up needing to rework anything on my end!

Comment 6 by agrieve@chromium.org, Oct 3

Status: WontFix (was: Assigned)
Looks like this isn't an issue for downstream.
►

Sign in to add a comment