The VR UI is currently drawn with native GL. On windows, however, we will make use of the command buffer.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/107706c9d8107b800c3aecc2b04f730db445052e commit 107706c9d8107b800c3aecc2b04f730db445052e Author: Aldo Culquicondor <acondor@chromium.org> Date: Fri Sep 21 02:49:34 2018 VR UI: Wrap GL bindings This wrapper allows to use the same macros for GL commands. They will make use of native GL or the command buffer, depending on the platform. Windows is the first platform to use the command buffer. All vr targets build for all platforms, but they fail to run on Windows, due to missing dependencies. These will be added in a followup CL. For now, disable the tests from the trybots. Bug: 884256 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8802ea37a82cd29d4356e7d4601952077d20dd4a Reviewed-on: https://chromium-review.googlesource.com/1226028 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#593061} [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/android/vr/BUILD.gn [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/component_updater/vr_assets_component_installer.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/browser_renderer.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/elements/controller.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/elements/environment/background.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/elements/environment/background.h [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/elements/environment/stars.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/elements/textured_element.h [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/elements/ui_texture.cc [add] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/gl_bindings.h [rename] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/native_gl_surface_provider.cc [rename] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/native_gl_surface_provider.h [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/renderers/base_quad_renderer.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/renderers/base_renderer.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/renderers/base_renderer.h [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/renderers/textured_quad_renderer.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/skia_surface_provider.h [add] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/skia_surface_provider_factory.h [add] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/skia_surface_provider_factory_cmd_buffer.cc [add] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/skia_surface_provider_factory_native_gl.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/test/gl_test_environment.h [add] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/test/gl_test_environment_cmd_buffer.cc [rename] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/test/gl_test_environment_native_gl.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/test/gl_test_environment_unittest.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/test/run_all_pixeltests.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/test/ui_pixel_test.cc [add] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/test/vr_gl_test_suite.cc [add] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/test/vr_gl_test_suite.h [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/text_perftest.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/ui.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/ui_element_renderer.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/ui_element_renderer.h [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/ui_renderer.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/vr_gl_util.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/chrome/browser/vr/vr_gl_util.h [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/ui/gl/gl_context_glx_unittest.cc [modify] https://crrev.com/107706c9d8107b800c3aecc2b04f730db445052e/ui/gl/test/gl_image_test_support.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9152d53ff4f0ed59c1d9e149c463e384dead73a1 commit 9152d53ff4f0ed59c1d9e149c463e384dead73a1 Author: Aldo Culquicondor <acondor@chromium.org> Date: Tue Sep 25 14:55:14 2018 VR: Add Skia surface provider for command buffer This is the last piece necessary in the VR UI to support the command buffer. Re-enable pixeltest for Windows. Bug: 884256 , 771794 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8c0a67021c859a88b0af519ace97266a142ec7d7 Reviewed-on: https://chromium-review.googlesource.com/1238816 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593933} [modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/BUILD.gn [add] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/cmd_buffer_surface_provider.cc [add] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/cmd_buffer_surface_provider.h [modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/skia_surface_provider_factory_cmd_buffer.cc [modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/test/gl_test_environment_unittest.cc [modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/test/run_all_perftests.cc [modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/test/ui_pixel_test.cc [modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/test/vr_gl_test_suite.cc [modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/text_perftest.cc [modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/ui_pixeltest.cc [modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/testing/buildbot/chromium.win.json [modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/testing/buildbot/test_suite_exceptions.pyl
Comment 1 by bugdroid1@chromium.org
, Sep 21