New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 884252 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Chromite preupload_dump_config does not notice changes to luci-scheduler.cfg

Project Member Reported by dgarr...@chromium.org, Sep 14

Issue description

The chromite presubmit check for chromeos_config generated files doesn't include the new generated file.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/25ef2edad98c700c5ab8483f79d6953f37971ad8

commit 25ef2edad98c700c5ab8483f79d6953f37971ad8
Author: Don Garrett <dgarrett@google.com>
Date: Mon Sep 17 17:25:04 2018

preupload_dump_config: Include luci-scheduler.cfg.

Revise the presubmit test to include all generated files. We have a
single unittest which covers them all. Use it to avoid needing to
remember to update this script in the future. Failures of that
unittest include instructions for how to regenerate the files in
question.

This is a change in behavior, since the presubmit will no longer
update the files in question, only check to see if they are current.

BUG= chromium:884252 
TEST=Manual testing with https://crrev.com/c/1180509

Change-Id: I25034dde0a1f712e20de246a5ce06db97a30e203
Reviewed-on: https://chromium-review.googlesource.com/1226172
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/25ef2edad98c700c5ab8483f79d6953f37971ad8/bin/preupload_dump_config

Status: Fixed (was: Started)

Sign in to add a comment