feedback reports always missing CLIENT_ID |
|||||||||||
Issue descriptionfeedback reports have blank CLIENT_ID fields, or more recently, always say "consent not given". testing locally, even after giving consent, the feedback reports continue to incorrectly say that. the problem is due to https://chromium-review.googlesource.com/1053426 where we moved debugd into a restricted mount namespace when `metrics_client -i` runs, it checks the "/home/chronos/Consent To Send Stats" path which is mounted from the encrypted stateful partition. debugd doesn't have that mount in its view, so metrics_client always fails. we can hack around it for now, but imo that flag file needs to move from /home/chronos to somewhere under /var.
,
Sep 14
I'd say the borders on P0 as it seriously undermines our ability to investigate crashes reported through feedback reports. 69 is already late and I don't want to hold it further, but we should not let 70 go to stable without a fix for this.
,
Sep 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b035099bb46f18c317db645c909d750aec5b3e73 commit b035099bb46f18c317db645c909d750aec5b3e73 Author: Mike Frysinger <vapier@chromium.org> Date: Sun Sep 16 11:04:35 2018 debugd: fix CLIENT_ID gathering after sandboxing work After we moved debugd into a unique mount namespace, we lost access to the consent id file. Since we want that for feedback reports, make sure metrics_client runs in a mount namespace where that file is actually readable. BUG= chromium:884249 TEST=generating feedback log now includes CLIENT_ID Change-Id: I5f6908d679edb468c41c030a0919b678f6cf493c Reviewed-on: https://chromium-review.googlesource.com/1226343 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> [modify] https://crrev.com/b035099bb46f18c317db645c909d750aec5b3e73/debugd/src/log_tool.cc
,
Sep 16
,
Sep 16
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 17
Merge approved M69.
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/62f76b1a7bdcc0072ce13245cb2b580828a97e84 commit 62f76b1a7bdcc0072ce13245cb2b580828a97e84 Author: Mike Frysinger <vapier@chromium.org> Date: Mon Sep 17 22:25:53 2018 debugd: fix CLIENT_ID gathering after sandboxing work After we moved debugd into a unique mount namespace, we lost access to the consent id file. Since we want that for feedback reports, make sure metrics_client runs in a mount namespace where that file is actually readable. BUG= chromium:884249 TEST=generating feedback log now includes CLIENT_ID Change-Id: I5f6908d679edb468c41c030a0919b678f6cf493c Reviewed-on: https://chromium-review.googlesource.com/1226343 (cherry picked from commit b035099bb46f18c317db645c909d750aec5b3e73) Reviewed-on: https://chromium-review.googlesource.com/1228605 Reviewed-by: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/62f76b1a7bdcc0072ce13245cb2b580828a97e84/debugd/src/log_tool.cc
,
Sep 21
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 21
dumb bot is dumb. R69 has already been merged, but still waiting on R70 approval.
,
Sep 21
Issue 888116 has been merged into this issue.
,
Sep 21
Thanks.
,
Sep 24
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/dc299f64417f40a554e10163e9aae6d2ec67b20a commit dc299f64417f40a554e10163e9aae6d2ec67b20a Author: Mike Frysinger <vapier@chromium.org> Date: Mon Sep 24 20:46:50 2018 debugd: fix CLIENT_ID gathering after sandboxing work After we moved debugd into a unique mount namespace, we lost access to the consent id file. Since we want that for feedback reports, make sure metrics_client runs in a mount namespace where that file is actually readable. BUG= chromium:884249 TEST=generating feedback log now includes CLIENT_ID Change-Id: I5f6908d679edb468c41c030a0919b678f6cf493c Reviewed-on: https://chromium-review.googlesource.com/1226343 (cherry picked from commit b035099bb46f18c317db645c909d750aec5b3e73) Reviewed-on: https://chromium-review.googlesource.com/1228604 Reviewed-by: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/dc299f64417f40a554e10163e9aae6d2ec67b20a/debugd/src/log_tool.cc
,
Sep 24
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by afakhry@chromium.org
, Sep 14