Print Preview: Text overflows from long printer names |
|||
Issue descriptionPre-refresh, long printer names were shortened with ellipses. Now the names run all the way to the edge of the sidebar and are cut off.
,
Sep 17
Issue 884744 has been merged into this issue.
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50bc4aaebd46c013d0fbb8159184babddf0b6e51 commit 50bc4aaebd46c013d0fbb8159184babddf0b6e51 Author: rbpotter <rbpotter@chromium.org> Date: Tue Sep 18 00:03:18 2018 Print Preview refresh: Fix some bugs (1) Ensure there is always 8px spacing between print and cancel buttons, regardless of their ordering (differs on Windows vs other OSes) (2) Do not allow text to overflow to the edge of the sidebar; use margin to provide space for ripples instead. (3) Remove elevation that shows up on more settings button when it is clicked. Bug: 884247 , 884246 Change-Id: I153ae9f497f94b18862780db318c3dbc98201f23 Reviewed-on: https://chromium-review.googlesource.com/1227352 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#591884} [modify] https://crrev.com/50bc4aaebd46c013d0fbb8159184babddf0b6e51/chrome/browser/resources/print_preview/new/advanced_options_settings.html [modify] https://crrev.com/50bc4aaebd46c013d0fbb8159184babddf0b6e51/chrome/browser/resources/print_preview/new/header.html [modify] https://crrev.com/50bc4aaebd46c013d0fbb8159184babddf0b6e51/chrome/browser/resources/print_preview/new/more_settings.html [modify] https://crrev.com/50bc4aaebd46c013d0fbb8159184babddf0b6e51/chrome/browser/resources/print_preview/new/print_preview_shared_css.html [modify] https://crrev.com/50bc4aaebd46c013d0fbb8159184babddf0b6e51/chrome/browser/resources/print_preview/new/settings_section.html [modify] https://crrev.com/50bc4aaebd46c013d0fbb8159184babddf0b6e51/chrome/browser/resources/print_preview/new/settings_select.html
,
Sep 19
Update : Retested above issue (using steps mentioned in issue 884604 ) on Win(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) OS using latest Canary #71.0.3556.0 and issue is fixed. Now the long text in destination is not seen chopped. Kindly review the attached screen-cast. Thank you..!!
,
Sep 19
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rbpotter@chromium.org
, Sep 17