New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 884240 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 836886



Sign in to add a comment

[BGPT] images/cross-fade-invalidation.html is flaky

Project Member Reported by wangxianzhu@chromium.org, Sep 14

Issue description

See https://test-results.appspot.com/data/layout_results/linux-blink-gen-property-trees/470/layout-test-results/results.html

Though the test is written in a flaky way, it constantly pass on other normal bots without BGPT.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/726e68d05c3db9d60cbfe889fa2541456a81a6a9

commit 726e68d05c3db9d60cbfe889fa2541456a81a6a9
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Sep 14 18:46:33 2018

[BGPT] Update FlagExpectations/enable-blink-gen-property-trees

TBR=pdr@chromium.org

Bug: 884239, 884240 
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iafece0358cf595c3055c481ac7af7368dde110f7
Reviewed-on: https://chromium-review.googlesource.com/1226354
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591413}
[modify] https://crrev.com/726e68d05c3db9d60cbfe889fa2541456a81a6a9/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees

Owner: pdr@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4a839a27a2c27739179e085bf7acc8139c1e1fc

commit f4a839a27a2c27739179e085bf7acc8139c1e1fc
Author: Philip Rogers <pdr@chromium.org>
Date: Thu Oct 04 18:17:40 2018

[BlinkGenPropertyTrees] SVG animations should not reset layer invalidations

When an SVG image has animations, SVGImage::ServiceAnimations is called
which updates animations via DocumentAnimations::UpdateAnimations. For
blink generated property trees (BGPT), this is done during paint (see:
LocalFrameView::RunPaintLifecyclePhase) and, because paint is skipped
when updating svg image animations, it must be explicitly invoked for
svg animations. (For non-BGPT, this is done as part of the compositing
step which precedes paint). Updating animations may invalidate the SVG
image's paint layers.

Before this patch, the paint layer invalidations were cleared which
caused the later svg image paint to incorrectly use stale paint data.

Bug:  884240 
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If21335672f55db0b937505c6475f55def0be14ac
Reviewed-on: https://chromium-review.googlesource.com/c/1261718
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596760}
[modify] https://crrev.com/f4a839a27a2c27739179e085bf7acc8139c1e1fc/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/f4a839a27a2c27739179e085bf7acc8139c1e1fc/third_party/blink/renderer/core/svg/graphics/svg_image.cc

Status: Fixed (was: Assigned)

Sign in to add a comment