Improve BrowserSwitcherSitelist coverage |
|
Issue descriptionBrowserSwitcherSitelist unit tests don't cover all accepted URL formats. Most notably, we should add tests for these kinds of URLs: - '//example.com' should any schema - 'example.com/something' should match any schema
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4439f2437ce432a3f5b900c084fbe5c06b35f6f0 commit 4439f2437ce432a3f5b900c084fbe5c06b35f6f0 Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Date: Tue Sep 18 14:55:58 2018 [BrowserSwitcher] Add tests for schema-less URLs Bug: 884221 Change-Id: Iaee4d979888e3bc5acf55f88c3618fd33810adf6 Reviewed-on: https://chromium-review.googlesource.com/1226025 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#592038} [modify] https://crrev.com/4439f2437ce432a3f5b900c084fbe5c06b35f6f0/chrome/browser/browser_switcher/browser_switcher_sitelist.cc [modify] https://crrev.com/4439f2437ce432a3f5b900c084fbe5c06b35f6f0/chrome/browser/browser_switcher/browser_switcher_sitelist_unittest.cc |
|
►
Sign in to add a comment |
|
Comment 1 by nicolaso@chromium.org
, Sep 18