New issue
Advanced search Search tips

Issue 884220 link

Starred by 1 user
Status: Fixed
Owner:
kinuko@chromium.org
Closed: Sep 28
Cc:
horo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Buggy use of base::AutoReset in content/browser/loader/data_pipe_to_source_stream.cc

Project Member Reported by mpawlow...@opera.com, Sep 14 
https://cs.chromium.org/chromium/src/content/browser/loader/data_pipe_to_source_stream.cc?rcl=c0e3a0bdbbac8a81a01394067057bd83bc2a0600&l=36

The RAII base::AutoReset<bool> object is not named, and thus gets deleted immediately. inside_read_ member is NOT temporarily set to true for the duration of this scope.

Introduced by https://chromium-review.googlesource.com/c/chromium/src/+/890156

Comment 1 by mmenke@chromium.org, Sep 14

Cc: -kinuko@chromium.org
Owner: kinuko@chromium.org
Status: Assigned (was: Untriaged)
Assigning to Kinuko (Mostly to get out of the network team's triage queue, since there's apparently no signed exchange label)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/479f8d9d6c7ebf7f8eab1f45eb0b84f32131ce6f

commit 479f8d9d6c7ebf7f8eab1f45eb0b84f32131ce6f
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Fri Sep 28 07:38:03 2018

Fix the buggy usage of base::AutoReset in data_pipe_to_source_stream.cc

Bug:  884220 
Change-Id: I02ab44bb09d69a75bfdc5336fb1250a7b574c758
Reviewed-on: https://chromium-review.googlesource.com/1250501
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595009}
[modify] https://crrev.com/479f8d9d6c7ebf7f8eab1f45eb0b84f32131ce6f/content/browser/loader/data_pipe_to_source_stream.cc

Comment 3 by kinuko@chromium.org, Sep 28

Status: Fixed (was: Assigned)
►

Sign in to add a comment