New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 884219 link

Starred by 0 users
Status: Fixed
Owner:
█ vabr@chromium.org
hobby only
Closed: Sep 26
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

PasswordManager.TotalAccounts should be marked as a base histogram

Project Member Reported by vabr@chromium.org, Sep 14 
PasswordManager.TotalAccounts is the base of a cascade of prefixes. Nothing is logged into it, only in its 4 grandchildren:

PasswordManager.TotalAccounts.{AutoGenerated|UserCreated}.{WithCustomPassphrase|WithoutCustomPassphrase}

Similarly, nothing is logged into PasswordManager.TotalAccountsHiRes.WithScheme, only in its children.

https://chromium.googlesource.com/chromium/src/+/lkcr/tools/metrics/histograms#histogram-suffixes suggests to mark histograms which are not logged into, but only serving as a base, as base="true", to stop confusing tools.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df844a6b24fd66f6c725eae210b8a4ce9a53786d

commit df844a6b24fd66f6c725eae210b8a4ce9a53786d
Author: Vaclav Brozek <vabr@chromium.org>
Date: Thu Sep 20 08:11:02 2018

Mark PasswordManager.TotalAccounts* as base histogram

Neither PasswordManager.TotalAccounts and
PasswordManager.TotalAccountsHiRes.WithScheme is logged directly into,
but they serve as a base for suffixes.

In particular, PasswordManager.TotalAccounts used to be logged into,
but is no more (since [1]), so the UMA data shows a steady decline in
its numbers (while the suffixes show growth).

Therefore, this CL marks those histograms as base.

The CL also completes the description and updates the owners of the
former histogram (gcasto@ left the project some years ago).

[1] https://chromium.googlesource.com/chromium/src/+/e015fd92a519f7c9cbc12ae341e18b650eaab1d3

Bug:  884219 
Change-Id: I98f94df53ef3280297c3e6ce3de81dfe2ef442f0
Reviewed-on: https://chromium-review.googlesource.com/1225768
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592719}
[modify] https://crrev.com/df844a6b24fd66f6c725eae210b8a4ce9a53786d/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a6d1fd9eeb58fcf244c0e38c20c58b2a844fbbe

commit 1a6d1fd9eeb58fcf244c0e38c20c58b2a844fbbe
Author: Vaclav Brozek <vabr@chromium.org>
Date: Wed Sep 26 07:49:30 2018

Mark histogram suffixes PasswordGenerated as base

The PasswordGenerated <histogram_suffixes> contains two suffixes,
AutoGenerated and UserCreated, applied to 3 histograms. In all those 6
combined cases, no data is logged into that resulting histogram,
instead it serves as a base for further suffixing.

Therefore this CL follows the advice from
https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#histogram-suffixes
and marks those suffixes as base.

Bug:  884219 
Change-Id: I7b6b68a23c74ac842835fba8ef632075402cfe1d
Reviewed-on: https://chromium-review.googlesource.com/1242926
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594242}
[modify] https://crrev.com/1a6d1fd9eeb58fcf244c0e38c20c58b2a844fbbe/tools/metrics/histograms/histograms.xml

Comment 3 by vabr@chromium.org, Sep 26

Status: Fixed (was: Started)
►

Sign in to add a comment