Issue metadata
Sign in to add a comment
|
Spellcheck suggestions broke in Chrome Beta 70
Reported by
lquinn@blackberry.com,
Sep 14
|
||||||||||||||||||||
Issue descriptionSteps to reproduce the problem: 1. Go to a simple HTML textarea such as https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#Example 2. Type a misspelled word such as "testt". 3. Observe the red underline indicating a misspelling. Tap the misspelled word. What is the expected behavior? Using Chrome 69 on the same device, I see a list of spelling suggestions ("Test", "tests", test", "testy") along with "Add to dictionary" and "Delete" options. What went wrong? Using Chrome Beta 70, nothing happens when tapping on the misspelled word. Did this work before? Yes 69.0.3497.91 Chrome version: 70.0.3538.17 Channel: beta OS Version: 5.0.2 Flash Version: I tested using an HTC One running Android 5.0.2 with the default HTC Sense Input keyboard.
,
Sep 24
jinsukkim@, I think this regression was caused by https://crrev.com/578223. Using the chromium-browser-snapshots builds, I can reproduce the issue with rev 578227 but not with rev 578222. Looking at the changes between those two builds, only 578223 stands out as a suspect.
,
Sep 24
This is still broken in Chrome Beta 70.0.3538.27.
,
Sep 27
,
Sep 28
I get no red lines on misspelled words on Chrome (69.0.3497.91) while I can on other apps (like Notepad). I haven't paid attention to this feature so might need more info. - What is your device brand/model, and OS version? - Tried enabling the feature by Settings -> Languages & Input -> Virtual Keyboard -> Gboard -> Text Correction -> Spell check. Is that how you configure the input settings?
,
Sep 28
I tested using an HTC One running Android 5.0.2 with the default HTC Sense Input keyboard. It doesn't seem that Gboard does spellcheck with Chrome, but you can see a similar issue on a Pixel 2 running Android 9 if you install the SwiftKey Keyboard (https://play.google.com/store/apps/details?id=com.touchtype.swiftkey). Using the SwiftKey Keyboard with US English as the input language, I get red lines on misspelled words using Chrome 69.0.3497.100. I don't get red lines on misspelled words using Chrome Beta 70.0.3538.32. That's a bit different than what I see on the HTC One running Chrome Beta 70.0.3538.32. On the HTC One, I get red lines on misspelled words with both Chrome 69 and Chrome Beta 70, but only Chrome 69 offers suggestions when I tap the misspelled word. I hope we can get this regression fixed before Chrome 70 becomes the stable version. I expect that many of our users will be upset to lose spellcheck suggestions.
,
Sep 30
Thanks for the info. I was able to reproduce it on Nexus 7 (6.0.1) + Gboard.
,
Oct 1
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone. All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 1
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cb89c1171e1f5dec93ff94595fde5d83a761c78 commit 9cb89c1171e1f5dec93ff94595fde5d83a761c78 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Mon Oct 01 22:38:10 2018 Android: Fix the bug not showing text suggestion Lazy init (https://crrev.com/578223) doesn't work for TextSuggestionHost whose UI gets triggered by native from Blink. It expects the related components (java TextSuggestionHost and blink::mojom::TextSuggestionHost) to be ready before it makes the first call. This CL initializes the objects in eager fashion. Bug: 884214 Change-Id: I1ef96d7d617a1fb745f2652a7e1f94e5d9406a24 Reviewed-on: https://chromium-review.googlesource.com/1253312 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#595608} [modify] https://crrev.com/9cb89c1171e1f5dec93ff94595fde5d83a761c78/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
,
Oct 1
,
Oct 1
,
Oct 1
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2
Will wait for this to land in Canary to make sure no side effects before approving the merge.
,
Oct 2
I could repro this issue, will wait for canary to verify the fix. I am changing it to RBS as this issue exists in few previous play store betas.
,
Oct 3
The NextAction date has arrived: 2018-10-03
,
Oct 3
Can we verify this is fixed in canary please?
,
Oct 3
Verified the fix on canary 71.0.3569.0 - Essesntial PH/N , I see "Add to dictionary" and "Delete" options.
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1717ee115b90c4c113442f8291c6cb185bd3d8e4 commit 1717ee115b90c4c113442f8291c6cb185bd3d8e4 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Thu Oct 04 02:47:54 2018 Android: Create Java TextSuggestionHost lazily This CL addresses the reported bug by undoing the quick fix http://crrev.com/595608 and lazily initializing Java side TextSuggestionHost properly. Native side still needs to be established eagerly to get the IPC to work. Now Java layer is created before suggestion menu is requested to be shown for the first time. Bug: 884214 Change-Id: I1bbe9b2e3a5898d6dd082f8784951215a4a9ab91 Reviewed-on: https://chromium-review.googlesource.com/c/1256383 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596487} [modify] https://crrev.com/1717ee115b90c4c113442f8291c6cb185bd3d8e4/content/browser/android/ime_adapter_android.cc [modify] https://crrev.com/1717ee115b90c4c113442f8291c6cb185bd3d8e4/content/browser/android/text_suggestion_host_android.cc [modify] https://crrev.com/1717ee115b90c4c113442f8291c6cb185bd3d8e4/content/browser/android/text_suggestion_host_android.h [modify] https://crrev.com/1717ee115b90c4c113442f8291c6cb185bd3d8e4/content/public/android/java/src/org/chromium/content/browser/input/TextSuggestionHost.java [modify] https://crrev.com/1717ee115b90c4c113442f8291c6cb185bd3d8e4/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
,
Oct 4
Approved for merge to 70, branch 3538.
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdd122364f7b519a86eec336ced96f9a639c08f6 Commit: bdd122364f7b519a86eec336ced96f9a639c08f6 Author: jinsukkim@chromium.org Commiter: jinsukkim@chromium.org Date: 2018-10-04 22:20:20 +0000 UTC Android: Fix the bug not showing text suggestion Lazy init (https://crrev.com/578223) doesn't work for TextSuggestionHost whose UI gets triggered by native from Blink. It expects the related components (java TextSuggestionHost and blink::mojom::TextSuggestionHost) to be ready before it makes the first call. This CL initializes the objects in eager fashion. TBR=tedchoc@chromium.org Bug: 884214 Change-Id: I1ef96d7d617a1fb745f2652a7e1f94e5d9406a24 Reviewed-on: https://chromium-review.googlesource.com/1253312 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#595608}(cherry picked from commit 9cb89c1171e1f5dec93ff94595fde5d83a761c78) Reviewed-on: https://chromium-review.googlesource.com/c/1263295 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#865} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdd122364f7b519a86eec336ced96f9a639c08f6 commit bdd122364f7b519a86eec336ced96f9a639c08f6 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Thu Oct 04 22:20:20 2018 Android: Fix the bug not showing text suggestion Lazy init (https://crrev.com/578223) doesn't work for TextSuggestionHost whose UI gets triggered by native from Blink. It expects the related components (java TextSuggestionHost and blink::mojom::TextSuggestionHost) to be ready before it makes the first call. This CL initializes the objects in eager fashion. TBR=tedchoc@chromium.org Bug: 884214 Change-Id: I1ef96d7d617a1fb745f2652a7e1f94e5d9406a24 Reviewed-on: https://chromium-review.googlesource.com/1253312 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#595608}(cherry picked from commit 9cb89c1171e1f5dec93ff94595fde5d83a761c78) Reviewed-on: https://chromium-review.googlesource.com/c/1263295 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#865} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/bdd122364f7b519a86eec336ced96f9a639c08f6/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
,
Oct 4
,
Oct 10
Works as per expected behavior, Issue verified on 70.0.3538.53
,
Oct 11
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by chelamcherla@chromium.org
, Sep 17