Develop IdentityManager::Observer::OnRefreshTokensLoaded() API that corresponds to O2TS::Observer::OnRefreshTokensLoaded() |
|||||
Issue descriptionIdeally we would get rid of this notification entirely by hiding the loading of tokens from disk within the Identity Service as an implementation detail, but that's a long-term design goal (see crbug.com/749535 ). In the meantime it has a non-negligible number of consumers, so we should develop an equivalent IdentityManager::Observer API to facilitate porting.
,
Sep 26
Unittests of the new API should be added that are similar to the unittests of the existing IdentityManager::Observer APIs: triggering the observer callback from the backing PO2TS object and verifying that a callback reaches an IdentityManager::Observer.
,
Sep 26
,
Sep 27
taking this
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d94b2c31d2d1f5e7d8667c364f1ffeae8dd5bd80 commit d94b2c31d2d1f5e7d8667c364f1ffeae8dd5bd80 Author: Sergio Villar Senin <svillar@igalia.com> Date: Mon Oct 08 09:20:25 2018 Add IdentityManager::Observer::OnRefreshTokensLoaded() API It corresponds to O2TS::Observer::OnRefreshTokensLoaded(). The loading of tokens from disk should ideally be an implementation detail of identity service but as there is a non trivial amount of consumers we should add this API to ease the transition. Bug: 884205 Change-Id: Ica449d4461e16c1a2652d1acdf8fc23939eca8ad Reviewed-on: https://chromium-review.googlesource.com/c/1251264 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597500} [modify] https://crrev.com/d94b2c31d2d1f5e7d8667c364f1ffeae8dd5bd80/services/identity/public/cpp/identity_manager.cc [modify] https://crrev.com/d94b2c31d2d1f5e7d8667c364f1ffeae8dd5bd80/services/identity/public/cpp/identity_manager.h [modify] https://crrev.com/d94b2c31d2d1f5e7d8667c364f1ffeae8dd5bd80/services/identity/public/cpp/identity_manager_unittest.cc
,
Oct 8
Closing... |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by blundell@chromium.org
, Sep 18