New issue
Advanced search Search tips

Issue 884202 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 26
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Set correct fields for Icon loading requests

Project Member Reported by na...@chromium.org, Sep 14 
The spec says (here: https://wicg.github.io/background-fetch/#background-fetch-display), that:
The UI may select an icon for display from bgFetch’s icons, and fetch it using a new request with the following properties:

URL 
The ImageResource's src.

Client 
environment.

Keepalive flag 
Set.

Service-workers mode 
"none".

Destination 
"image".

Mode 
"no-cors".

Credentials mode 
"include".

We should set these before passing the request on to the loader.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4849adf30e2ad3636e4cc4aa4714d2e726333742

commit 4849adf30e2ad3636e4cc4aa4714d2e726333742
Author: Mugdha Lakhani <nator@chromium.org>
Date: Tue Sep 18 11:52:23 2018

[Background Fetch] Add fields to the request for loading an icon.

This is per the spec:
https://wicg.github.io/background-fetch/#background-fetch-display

Bug:  884202 
Change-Id: I01328856966c6065a4aca382923f219c92079366
Reviewed-on: https://chromium-review.googlesource.com/1228199
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592001}
[modify] https://crrev.com/4849adf30e2ad3636e4cc4aa4714d2e726333742/third_party/blink/renderer/modules/background_fetch/background_fetch_icon_loader.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0fd8af38305b576552023787a197b27c6b03418

commit d0fd8af38305b576552023787a197b27c6b03418
Author: Mugdha Lakhani <nator@chromium.org>
Date: Wed Sep 26 11:22:51 2018

[Background Fetch] SkipServiceWorker when loading icon.

The fetch request we use to fetch the icon for Background Fetch
should have service-workers mode set to "none", according to the spec.
https://wicg.github.io/background-fetch/#background-fetch-display

This CL makes that change.

Bug:  884202 
Change-Id: Ie027529326cbd4f88bf37b012afeb8460b6c1ef1
Reviewed-on: https://chromium-review.googlesource.com/1245370
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594280}
[modify] https://crrev.com/d0fd8af38305b576552023787a197b27c6b03418/third_party/blink/renderer/modules/background_fetch/background_fetch_icon_loader.cc

Comment 3 by na...@chromium.org, Sep 26

Status: Fixed (was: Available)
►

Sign in to add a comment