New issue
Advanced search Search tips

Issue 884171 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Sep 21
Cc:
stkhapugin@chromium.org
pschaffner@chromium.org
gambard@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Address bar does not dim on tap

Reported by jeffreyc...@gmail.com, Sep 14 
Steps to reproduce the problem:
1. Tap and hold the address bar
2. 
3. 

What is the expected behavior?
There should be some feedback by dimming the address bar when tapped on. See Safari address bar for example.

It's also dimmed on macOS when you hover over the address bar.

What went wrong?
Address bar does not change colour, as if it does not register the tap and hold.

Did this work before? N/A 

Chrome version: 70.0.3538.16  Channel: beta
OS Version: OS X 10.13.6
Flash Version:

Comment 1 by stkhapugin@chromium.org, Sep 14

Cc: gambard@chromium.org stkhapugin@chromium.org pschaffner@chromium.org
Components: -UI UI>Browser>Omnibox UI>Browser>Toolbar
Labels: Proj-UIRefresh
Owner: gambard@chromium.org
Status: Assigned (was: Unconfirmed)
Thank you for reporting this!

We need to change the background color of the omnibox background view when the tap is down.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c53f4de167acf3977e9d715bdcb07ce3a79b9c40

commit c53f4de167acf3977e9d715bdcb07ce3a79b9c40
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Sep 21 12:13:12 2018

[iOS] Add highlighted color to the steady view

This CL changes the color of the steady view when it is highlighted
to a darker color.

Bug:  884171 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I39c9197b8f2172881d60b0f5cdb624d3d37722e3
Reviewed-on: https://chromium-review.googlesource.com/1228058
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593154}
[modify] https://crrev.com/c53f4de167acf3977e9d715bdcb07ce3a79b9c40/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm

Comment 3 by gambard@chromium.org, Sep 21

Status: Fixed (was: Assigned)

Comment 4 by jeffreyc...@gmail.com, Oct 4 

What version should I see this fix in? I'm on 70.0.3538.44 and it's not dimming.

Comment 5 by gambard@chromium.org, Oct 4 

This would be available in Chrome 71.

Comment 6 by jeffreyc...@gmail.com, Oct 22 

Could you make it so that it fades back to normal colour when your finger moves out of the address bar? Notice on Safari if you hold your finger over the address bar and drag your finger out of it the colour fades out instead of abruptly.

Comment 7 by pschaffner@chromium.org, Oct 22 

Sure thing!

Comment 8 by gambard@chromium.org, Oct 25 

If I understand correctly, the issue you are reporting is that the darker color displayed in the address bar is disappearing abruptly instead of nicely fading out?

Comment 9 by jeffreyc...@gmail.com, Oct 25 

Yes, very minor detail

Comment 10 by gambard@chromium.org, Oct 25 

Thanks, I have created  issue 898951 .
►

Sign in to add a comment