New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 884170 link

Starred by 2 users
Status: Assigned
Owner:
einbinder@chromium.org
Cc:
█ krajshree@chromium.org
samans@chromium.org
m...@chromium.org
caseq@chromium.org
ccameron@chromium.org
pfeldman@chromium.org
dgozman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Color picker wildly inaccurate when using custom ICC profile in Windows and macOS (Possibly wide gamut display related only)

Reported by jason.to...@gmail.com, Sep 14 
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.92 Safari/537.36

Steps to reproduce the problem:
1. Set a custom ICC profile
2. Open Chrome and browse a site (themeforest.net for example)
3. Inspect any element to change foreground color (let's go with the heading text under the teal search section)
4. Choose the color for said text and let the color picker select an area of the teal in the search bar background
5. Look at the color value (wrong)

What is the expected behavior?
Should use the color values produced as a result of the custom ICC profile being used, not the color resulting from EDID (assuming that is what's happening here).

What went wrong?
Color values of color picker are inaccurate. In Windows, this is harder to see what is happening as the zoomed color area of the color picker is showing the color behind it (which is expected), however, in macOS the background of the color picker is clearly miles out from what the color picker should be showing.

Did this work before? Yes Guessing 68.x ?

Chrome version: 69.0.3497.92  Channel: stable
OS Version: 10.0
Flash Version: 

Chrome flags display profile set to default.

Comment 1 by susan.boorgula@chromium.org, Sep 16

Labels: Needs-Bisect Needs-Triage-M69

Comment 2 by krajshree@chromium.org, Sep 17

Cc: krajshree@chromium.org
Labels: Triaged-ET Needs-Feedback
reporter@ - Thanks for filing the issue...!!

Could you please provide a sample ICC profile to test the issue from TE-end. Also if possible please provide a screen shot/screen cast for better understanding of the issue.
Thanks...!!

Comment 3 by caseq@chromium.org, Sep 24

Cc: ccameron@chromium.org samans@chromium.org m...@chromium.org
Owner: caseq@chromium.org
Status: Assigned (was: Unconfirmed)
Yuri, Saman, does it look like an implication of issue 758057?

Comment 4 by samans@chromium.org, Sep 25 

I'm personally not familiar with how color space is handled for screenshots. I hope Yuri can provide some insights.

Comment 5 by m...@chromium.org, Sep 25

Blockedon: 758057

Comment 6 by m...@chromium.org, Sep 25 

The long and short of it: Screen capture currently ignores color space concerns. However, I have lots of stuff in-flight right now to fix that. :) So, please be patient.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed44fc45d0c3b3675efec4c550d28c5de1569c9d

commit ed44fc45d0c3b3675efec4c550d28c5de1569c9d
Author: Yuri Wiitala <miu@chromium.org>
Date: Sat Dec 15 03:14:24 2018

Complete the screen capture color space plumbing.

Adds all remaining "plumbing" of color space information, throughout the
CopyOutputRequest execution pipeline and the FrameSinkVideoCapturer
pipeline. This ensures the color space being used to draw the original
RenderPass within the compositor is being specified in the metadata for
all result images.

DevTools: Remove a hack from the color picker tool, now that the color
space information for the screen capture frame is being provided.

browser_tests/content_browsertests changes: Multilple browser tests were
fixed as a result of this change revealing pre-existing bugs in the
tests: the web page layout of the color regions, how pixels were being
selected for analysis, and YUV→RGB color space conversion inaccuracies.

Blink layout tests: Rebased a number of layout test expectations, as the
the layout tests utilize the screen capture pipeline. I examined all of
these changed expectations to confirm near 0% change: Meaning that just
a tiny number of pixels in an image were imperceivably different because
of adding the missing color space info.

Bug: 758057, 8510131,  809835 , 863103, 884170, 795132
Change-Id: I11056ddc4f501ee338dc3283397703747a395571
Reviewed-on: https://chromium-review.googlesource.com/c/1372894
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616936}
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/chrome/browser/devtools/devtools_eye_dropper.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/chrome/test/data/extensions/api_test/tab_capture/offscreen_end_to_end.js
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/common/frame_sinks/copy_output_result.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/common/frame_sinks/copy_output_result.h
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display/gl_renderer_copier.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display/skia_output_surface.h
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display_embedder/skia_output_surface_impl.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display_embedder/skia_output_surface_impl.h
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/interprocess_frame_pool.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/interprocess_frame_pool.h
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/video_capture_overlay.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/video_capture_overlay.h
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/video_capture_overlay_unittest.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/aura_window_video_capture_device_browsertest.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/content_capture_device_browsertest_base.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/fake_video_capture_stack.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/frame_test_util.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/frame_test_util.h
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/lame_window_capturer_chromeos.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/web_contents_video_capture_device_browsertest.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/remoting/host/chromeos/aura_desktop_capturer_unittest.cc
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/4402375-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/replaced-boundaries-1-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/replaced-boundaries-2-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/replaced-boundaries-3-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/paint/invalidation/svg/text-selection-text-05-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/foreignObject-text-clipping-bug-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/selection-doubleclick-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/selection-tripleclick-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-align-02-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-align-03-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-align-04-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-align-06-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-intro-05-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-path-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-spacing-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-03-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-06-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-08-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-ws-02-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/textPathBoundsBug-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac-mac10.10/editing/selection/replaced-boundaries-3-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac-mac10.11/editing/selection/replaced-boundaries-3-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/4402375-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/replaced-boundaries-1-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/replaced-boundaries-2-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/replaced-boundaries-3-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/paint/invalidation/svg/text-selection-text-05-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/foreignObject-text-clipping-bug-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/selection-doubleclick-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/selection-tripleclick-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-align-03-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-align-04-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-align-06-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-path-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-spacing-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-03-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-04-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-06-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-08-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-tselect-02-f-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-tspan-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-ws-01-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-ws-02-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/textPathBoundsBug-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/4402375-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/replaced-boundaries-1-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/replaced-boundaries-2-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/replaced-boundaries-3-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/paint/invalidation/svg/text-selection-text-05-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/foreignObject-text-clipping-bug-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/selection-tripleclick-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-02-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-03-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-04-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-05-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-06-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-path-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-spacing-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-text-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-text-03-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-text-06-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-text-08-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-tselect-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-tselect-02-f-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-tspan-01-b-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-ws-01-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-ws-02-t-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/textPathBoundsBug-expected.png
[delete] https://crrev.com/4c40f61f89ae4d0a196c2c7b14b696bb7b5e0430/third_party/blink/web_tests/platform/win7/editing/selection/replaced-boundaries-1-expected.png
[modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win7/svg/text/text-selection-text-08-b-expected.png
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98a8f01a27f97ec27e6315fb006e61cd59192d29

commit 98a8f01a27f97ec27e6315fb006e61cd59192d29
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Mon Dec 17 11:41:19 2018

[LayoutNG] Rebaseline test expectations after color space changes.

https://chromium-review.googlesource.com/c/chromium/src/+/1372894 made
some invisible (to the naked eye) rebaselining to some test
expectations, but not for LayoutNG.

TBR=kojii@chromium.org

Bug: 758057, 8510131,  809835 , 863103, 884170, 795132
Change-Id: Ie6b626c66c0930b1c8c00b7b01a0f01ddd06dada
Reviewed-on: https://chromium-review.googlesource.com/c/1379953
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617089}
[modify] https://crrev.com/98a8f01a27f97ec27e6315fb006e61cd59192d29/third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/98a8f01a27f97ec27e6315fb006e61cd59192d29/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/editing/selection/4402375-expected.png
[modify] https://crrev.com/98a8f01a27f97ec27e6315fb006e61cd59192d29/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/98a8f01a27f97ec27e6315fb006e61cd59192d29/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/svg/text/foreignObject-text-clipping-bug-expected.png

Comment 9 by m...@chromium.org, Dec 18 

Looking into this further, my understanding is that: 1) The web page assumes sRGB (e.g., when specifying CSS colors); and 2) The eye dropper color picker should be picking the the RGB values that one would set in CSS to achieve the same on-screen display; and 3) The display of the web page and overlaid zoomed color picker view (i.e., the custom mouse cursor) should match. IIUC, this bug is only claiming #3 is a problem.

To test, I set a ridiculous color calibration on my Windows machine: I turned red down a lot, and blue down a little. Thus, whites and grays all become very green, reds are darkened a lot, etc. Then, while using the color picker, I took a snapshot of the screen with my phone (attached). It's obvious that the color picker zoomed view is not respecting the color profile that I had set.

I believe the root cause is that the code in DevToolsEyeDropper::UpdateCursor() draws the custom mouse cursor without specifying the color space (in the allocN32Pixels() call on the SkBitmap that backs the SkCanvas). That should be fairly easy to fix (like, a one-liner code change). Then, we'd have to see if all the downstream code (i.e., RenderWidgetHost::SetCursor()) and the operating system itself would respect the color space of the custom cursor image.

Thus, at this point, I believe this issue is no longer blocked on 758057; and that the remainder of the problem can be fixed in the DevToolsEyeDropper UI code and, possibly, requiring downstream code changes.
picker_color_inaccuracy.png
1.7 MB View Download

Comment 10 by m...@chromium.org, Dec 18

Blockedon: -758057

Comment 11 by caseq@chromium.org, Dec 20

Cc: caseq@chromium.org dgozman@chromium.org pfeldman@chromium.org
Labels: -Needs-Feedback -Needs-Bisect -Needs-Triage-M69
Owner: einbinder@chromium.org
Joel, could you please follow up on the DevTools side?
►

Sign in to add a comment