New issue
Advanced search Search tips

Issue 884164 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.4%-15.6% regression in webrtc_perf_tests at 24671:24674

Project Member Reported by nisse@chromium.org, Sep 14

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=884164

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=0a88f0de591be344187f92b7d54728626ea5fc426e36afcefa1721b05fd02980


Bot(s) for this bug's original alert(s):

webrtc-win-large-tests
Owner: ssilkin@chromium.org
This looks like a regression from the reland #24669, https://webrtc-review.googlesource.com/99340, which didn't recover with #24686, https://webrtc-review.googlesource.com/99501.

It looks a bit different from https://bugs.chromium.org/p/chromium/issues/detail?id=884133, but might be same root cause.

Sergey, can you have a look?
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/f87bb463060c2374493226b537e13b69aa8e4d80

commit f87bb463060c2374493226b537e13b69aa8e4d80
Author: Sergey Silkin <ssilkin@webrtc.org>
Date: Tue Sep 18 17:25:39 2018

Restrict use of frame rate controller.

VP9 frame rate controller is supposed to be used in screen mode only
but it was partially enabled in normal video mode. This restricts use
of VP9 frame rate controller to screen mode.

Bug:  chromium:884164 
Change-Id: Ie2eaa31f3364a8abccbc4171007708cf7040fc38
Reviewed-on: https://webrtc-review.googlesource.com/100424
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24769}
[modify] https://crrev.com/f87bb463060c2374493226b537e13b69aa8e4d80/modules/video_coding/codecs/vp9/vp9_impl.cc

Issue 884133 has been merged into this issue.
Status: Fixed (was: Untriaged)
The regression has been fixed.
Screen Shot 2018-09-19 at 10.48.56 AM.png
796 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9abce3b979716c611816a6a07ec43e9c7beb145

commit a9abce3b979716c611816a6a07ec43e9c7beb145
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Sep 20 10:20:25 2018

Roll src/third_party/webrtc d574123c5035..ee002e61857b (32 commits)

https://webrtc.googlesource.com/src.git/+log/d574123c5035..ee002e61857b


git log d574123c5035..ee002e61857b --date=short --no-merges --format='%ad %ae %s'
2018-09-19 chfremer@webrtc.org Fix WebRTC fuzzers tests in Chromium missing field trial implementation
2018-09-19 yvesg@webrtc.org Roll chromium_revision e4b02117a9..cc7b9c6822 (592264:592452)
2018-09-19 yvesg@webrtc.org Auto roller: Fix GenerateCommitMessage signature.
2018-09-19 yvesg@webrtc.org Auto roller: fix list of WEBRTC_ONLY_DEPS.
2018-09-19 yvesg@webrtc.org Auto roller: don't complain about expected dependencies.
2018-09-19 yvesg@webrtc.org Auto roller: improved tracking of android dependencies.
2018-09-19 buildbot@webrtc.org Roll chromium_revision f305d23e18..e4b02117a9 (592151:592264)
2018-09-18 mbonadei@webrtc.org Fix WebRTC fuzzers tests in Chromium.
2018-09-18 buildbot@webrtc.org Roll chromium_revision f37f3783a3..f305d23e18 (591975:592151)
2018-09-18 ssilkin@webrtc.org Restrict use of frame rate controller.
2018-09-18 nisse@webrtc.org Simplify includes in p2ptransportchannel.cc
2018-09-18 sprang@webrtc.org Prevent resolution limited max bitrate from going below min
2018-09-18 mbonadei@webrtc.org Reland "Add RTC_EXPORT macro to export WebRTC symbols."
2018-09-18 mbonadei@webrtc.org Do not compile frame_analyzer_host during Chromium builds.
2018-09-18 mbonadei@webrtc.org Add documentation about field_trial/metrics custom impl.
2018-09-18 jtteh@webrtc.org Revert "Add RTC_EXPORT macro to export WebRTC symbols."
2018-09-18 mbonadei@webrtc.org Reland "Compile frame analyzer for the host machine on perf tests."
2018-09-18 buildbot@webrtc.org Roll chromium_revision 0eb6b522cc..f37f3783a3 (591627:591975)
2018-09-18 danilchap@webrtc.org Refactor RtpPacketizerH264 tests
2018-09-18 danilchap@webrtc.org Cleanup modules_common_types
2018-09-17 mbonadei@webrtc.org Revert "Compile frame analyzer for the host machine on perf tests."
2018-09-17 mbonadei@webrtc.org Add RTC_EXPORT macro to export WebRTC symbols.
2018-09-17 mbonadei@webrtc.org Compile frame analyzer for the host machine on perf tests.
2018-09-17 buildbot@webrtc.org Roll chromium_revision 1d75f6fc68..0eb6b522cc (591373:591627)
2018-09-17 mbonadei@webrtc.org Rename RTC_EXPORT to RTC_OBJC_EXPORT.
2018-09-17 mbonadei@webrtc.org Introduce GN arg rtc_exclude_runtime_enabled_features_default.
2018-09-17 danilchap@webrtc.org Register video rtp header extensions in rtp_rtcp by uri
2018-09-17 sprang@webrtc.org Add ability to throttle VideoBitrateAllocation updates.
2018-09-17 mbonadei@webrtc.org Remove obsolete comments.
2018-09-17 saza@webrtc.org Reland "Remove APM internal usage of EchoCancellation"
2018-09-15 mbonadei@webrtc.org Merge field_trial and field_trial_default in a unique target.
2018-09-15 mbonadei@webrtc.org Merge system_wrappers:metrics and system_wrappers:metrics_default.


Created with:
  gclient setdep -r src/third_party/webrtc@ee002e61857b

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:855108,chromium:855108,chromium:855108,chromium:855108,chromium:None,chromium:None,chromium:884164,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: If83dd14ed68cd0ebd408e229d672b44eedb9fb98
Reviewed-on: https://chromium-review.googlesource.com/1235418
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592746}
[modify] https://crrev.com/a9abce3b979716c611816a6a07ec43e9c7beb145/DEPS

Components: Blink>WebRTC>Video

Sign in to add a comment