New issue
Advanced search Search tips

Issue 884140 link

Starred by 1 user
Status: Verified
Owner:
charleszhao@chromium.org
Closed: Oct 22
Cc:
shend@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: AppSearchResultRankerSerializationTest.SaveToDiskSucceed



Sign in to add a comment

AppSearchResultRankerSerializationTest.SaveToDiskSucceed is flaky

Project Member Reported by Findit, Sep 14

Comment 1 by dtapu...@chromium.org, Sep 14

Components: UI>Browser

Comment 2 by shend@chromium.org, Sep 17

Cc: shend@chromium.org
Owner: charleszhao@chromium.org
Status: Assigned (was: Untriaged)
Error message:

[ RUN      ] AppSearchResultRankerSerializationTest.SaveToDiskSucceed
../../chrome/browser/ui/app_list/search/search_result_ranker/app_search_result_ranker_unittest.cc:206: Failure
Expected equality of these values:
  str_written
    Which is: "\n \n\xE\n\aTarget2\x15\0\0\0@\n\xE\n\aTarget1\x15\0\0\x80?"
  proto_str_
    Which is: "\n \n\xE\n\aTarget1\x15\0\0\x80?\n\xE\n\aTarget2\x15\0\0\0@"
With diff:
@@ -2,5 +2,5 @@
 \xE
-\aTarget2\x15\0\0\0@
+\aTarget1\x15\0\0\x80?
 \xE
-\aTarget1\x15\0\0\x80?
+\aTarget2\x15\0\0\0@
Stack trace:
#0 0x000008cdd3af (/b/s/w/ir/out/Release/unit_tests+0x8cdd3ae)
#1 0x000008d037a0 (/b/s/w/ir/out/Release/unit_tests+0x8d0379f)
#2 0x000008d0237a (/b/s/w/ir/out/Release/unit_tests+0x8d02379)
[  FAILED  ] AppSearchResultRankerSerializationTest.SaveToDiskSucceed (103 ms)
[ RUN      ] AppSearchResultRankerSerializationTest.SaveToDiskSucceed
../../chrome/browser/ui/app_list/search/search_result_ranker/app_search_result_ranker_unittest.cc:206: Failure
Expected equality of these values:
  str_written
    Which is: "\n \n\xE\n\aTarget2\x15\0\0\0@\n\xE\n\aTarget1\x15\0\0\x80?"
  proto_str_
    Which is: "\n \n\xE\n\aTarget1\x15\0\0\x80?\n\xE\n\aTarget2\x15\0\0\0@"
With diff:
@@ -2,5 +2,5 @@
 \xE
-\aTarget2\x15\0\0\0@
+\aTarget1\x15\0\0\x80?
 \xE
-\aTarget1\x15\0\0\x80?
+\aTarget2\x15\0\0\0@
Stack trace:
#0 0x000008cdd3af (/b/s/w/ir/out/Release/unit_tests+0x8cdd3ae)
#1 0x000008d037a0 (/b/s/w/ir/out/Release/unit_tests+0x8d0379f)
#2 0x000008d0237a (/b/s/w/ir/out/Release/unit_tests+0x8d02379)
[  FAILED  ] AppSearchResultRankerSerializationTest.SaveToDiskSucceed (36 ms)

Looks like some sort of race condition between two messages?

charleszhao@, could you take a look? Thanks!

Comment 3 by asanka@chromium.org, Sep 18 

So far SaveToDiskSucceeded is the only test that's flaky in that suite.

Since it looks like you are working on it, let's disable that test without reverting the whole CL. WDYT?
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8327c079a60682035695a35bb84693e6d6175e8

commit e8327c079a60682035695a35bb84693e6d6175e8
Author: Asanka Herath <asanka@chromium.org>
Date: Tue Sep 18 17:31:59 2018

Disable AppSearchResultRankerSerializationTest.SaveToDiskSucceed

Test is flaky.

Bug:  884140 
Change-Id: I41f4f3eb084edd56867ffecc437817be8f1bcc1b
Reviewed-on: https://chromium-review.googlesource.com/1231037
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592095}
[modify] https://crrev.com/e8327c079a60682035695a35bb84693e6d6175e8/chrome/browser/ui/app_list/search/search_result_ranker/app_search_result_ranker_unittest.cc

Comment 5 by asanka@chromium.org, Sep 18

Labels: -Sheriff-Chromium

Comment 6 by charleszhao@chromium.org, Sep 18 

Thanks shend for helping on this. I'm taking a look right now.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dc28b99abf2a960646313ff896a9b1682426361

commit 6dc28b99abf2a960646313ff896a9b1682426361
Author: Charles Zhao <charleszhao@chromium.org>
Date: Thu Sep 20 13:11:02 2018

cros: Fix two flaky tests.

Both tests fail because the proto serialization is not deterministic.

Change-Id: I3b99faa03c55b3333c1d03e05258985e6f8ddaa5

Bug:  884140 
Change-Id: I3b99faa03c55b3333c1d03e05258985e6f8ddaa5
Reviewed-on: https://chromium-review.googlesource.com/1233096
Commit-Queue: Charles . <charleszhao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592776}
[modify] https://crrev.com/6dc28b99abf2a960646313ff896a9b1682426361/chrome/browser/ui/app_list/search/search_result_ranker/app_launch_predictor_unittest.cc
[modify] https://crrev.com/6dc28b99abf2a960646313ff896a9b1682426361/chrome/browser/ui/app_list/search/search_result_ranker/app_search_result_ranker_unittest.cc

Comment 9 by robliao@chromium.org, Sep 26

Labels: Hotlist-DesktopUIConsider

Comment 10 by robliao@chromium.org, Sep 27

Labels: Group-Tests

Comment 11 by robliao@chromium.org, Sep 28

Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged

Comment 12 by charleszhao@chromium.org, Oct 22 

This bug is resolved and verified.

Comment 13 by charleszhao@chromium.org, Oct 22

Status: Verified (was: Assigned)
►

Sign in to add a comment