New issue
Advanced search Search tips

Issue 884090 link

Starred by 0 users
Status: Fixed
Owner:
johnchen@chromium.org
Closed: Sep 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Merge request for ChromeDriver whitelisted-ips option handling

Project Member Reported by johnchen@chromium.org, Sep 14 
Requesting merge of https://chromium-review.googlesource.com/1220474 to m70 branch. This CL fixes a ChromeDriver bug that caused the --whitelisted-ips option to be handled incorrectly. This fix was originally done under  issue chromedriver:2566 .

Note that these changes are in ChromeDriver directory (src/chrome/test/chromedriver), and Chrome does not depend on that at all, so these will have no impact on Chrome binary that is shipping. See go/chromedriver-versioning and go/chops-proj-rev-27 for background.
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 14

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by abdulsyed@chromium.org, Sep 14

Labels: -Merge-Review-70 Merge-Approved-70
branch:3538
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 14

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a838cb77b95756c0d17d80de063ae624c6c1be9

commit 2a838cb77b95756c0d17d80de063ae624c6c1be9
Author: John Chen <johnchen@chromium.org>
Date: Fri Sep 14 19:27:09 2018

[ChromeDriver] More robust match of whitelisted-ips

Previously, IP address matching for whitelisted-ips options was done by
string comparison, and was unreliable. In particular, it didn't handle
IPv4-mapped IPv6 addresses. To make the matching more robust, we now do
binary comparison using IPAddress object.

Bug:  884090 ,  chromedriver:2566 
Change-Id: I81430ecef60b44dbc40a976637cdb42ed50acde1
Reviewed-on: https://chromium-review.googlesource.com/1220474
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590483}(cherry picked from commit 03e154e379e5665cb625f7222bb2b0e0899901dc)
Reviewed-on: https://chromium-review.googlesource.com/1227291
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#418}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/2a838cb77b95756c0d17d80de063ae624c6c1be9/chrome/test/chromedriver/server/chromedriver_server.cc

Comment 4 by johnchen@chromium.org, Sep 17

Status: Fixed (was: Assigned)
►

Sign in to add a comment