Issue 884062 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	█ rameier@chromium.org Last visit 15 days ago
Closed:	Sep 24
Cc:	est...@chromium.org
Components:	UI>Browser>Themes
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Chrome , Mac
Pri:	2
Type:	Bug
M-70 proj-desktopui

Background tab text color contrast calculations ignore background tab tint

Project Member Reported by pkasting@chromium.org, Sep 14

Issue description

Load the attached unpacked test theme.  Note that background tab text is unreadable.

I wonder if the core problem here is that we don't compute the background tab color correctly when there's a tint but no manually-set image or color.  We seem to be computing text color to contrast against the frame color, instead of the (now tinted) background tab color.

Probably not worth trying to get into the next 69 respin, but we should at least merge to 70.

manifest.json
168 bytes View Download

Comment 1 by mateusro...@gmail.com, Sep 16

Well, I'm speaking as a user but...

I loaded the theme on my Chromium.
That theme is really, really bad.
See attached screenshot for how it looks.

One question though. It seems that when the tab strip or active tab has a light color as background, then the font is a gray closer to black. While if the tab strip or ative tab has a dark background, the font is a gray closer to white.

While I'm currently fine with that, would it be possible to change it so that for dark background it uses #FFFFFF White and for light backgrounds it uses #000000 Black?

I could file a separate bug for this request though.

	Screenshot from 2018-09-15 22-35-46.png 3.8 KB View Download

Comment 2 by pkasting@chromium.org, Sep 16

You can make your own custom theme using whichever foreground and background colors you like.

Comment 3 by rameier@chromium.org, Sep 19

Status: Started (was: Assigned)

Comment 4 by robliao@chromium.org, Sep 20

Labels: -Proj-MdRefresh Proj-DesktopUI

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f75989c1388c79a301bbed95b566a0d6baaea28f

commit f75989c1388c79a301bbed95b566a0d6baaea28f
Author: Ryan Meier <rameier@chromium.org>
Date: Mon Sep 24 18:13:42 2018

Properly handle tint in background tab text color calculation.

Bug:  884062 
Change-Id: I584dda328551a10db2100d493e802f42da83c1e5
Reviewed-on: https://chromium-review.googlesource.com/1237262
Commit-Queue: Ryan Meier <rameier@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593600}
[modify] https://crrev.com/f75989c1388c79a301bbed95b566a0d6baaea28f/chrome/browser/themes/browser_theme_pack.cc
[modify] https://crrev.com/f75989c1388c79a301bbed95b566a0d6baaea28f/chrome/browser/themes/browser_theme_pack_unittest.cc
[add] https://crrev.com/f75989c1388c79a301bbed95b566a0d6baaea28f/chrome/test/data/extensions/theme_test_bgtabtext_tintonly/manifest.json
[modify] https://crrev.com/f75989c1388c79a301bbed95b566a0d6baaea28f/ui/gfx/color_utils.cc
[modify] https://crrev.com/f75989c1388c79a301bbed95b566a0d6baaea28f/ui/gfx/color_utils_unittest.cc

Comment 6 by rameier@chromium.org, Sep 24

Status: Fixed (was: Started)

►

Issue 884062 link

Issue metadata

Background tab text color contrast calculations ignore background tab tint

Issue description

Comment 1 by mateusro...@gmail.com, Sep 16

Comment 1 Deleted

Comment 2 by pkasting@chromium.org, Sep 16

Comment 2 Deleted

Comment 3 by rameier@chromium.org, Sep 19

Comment 3 Deleted

Comment 4 by robliao@chromium.org, Sep 20

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Sep 24

Comment 5 Deleted

Comment 6 by rameier@chromium.org, Sep 24

Comment 6 Deleted

Sign in to add a comment