New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 884061 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 870128
issue 884065


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

Integrate skeleton MultiDeviceSetup page into OOBE

Project Member Reported by khorimoto@chromium.org, Sep 14

Issue description

The page belongs between the "assistant" and "one last thing" pages; see [1].

This task also includes *not* showing the page at all if the user does not have any eligible phones to use with their Chromebook.

I have a work-in-progress prototype CL for this at [2].

[1] https://docs.google.com/presentation/d/1U_ObeMIzR5RzjbOaLXbnpBabL8nBlmMUbpdCFoU6-4E/edit#slide=id.g3b73ef5920_0_628
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1223028
 
Blocking: 884065
Components: -UI>ProximityAuth UI>Multidevice
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4485f206bf90c99f3cb281b63325cdbfc95a0be

commit e4485f206bf90c99f3cb281b63325cdbfc95a0be
Author: Kyle Horimoto <khorimoto@google.com>
Date: Fri Sep 28 00:12:38 2018

[CrOS MultiDevice] Integrate skeleton MultiDevice page into OOBE.

This CL adds a page for the MultiDevice setup flow to OOBE when
associated flags are enabled. Currently, page is a placeholder with no
content except for two buttons which move the user to the next page in
the OOBE/login flow.

A follow-up CL will integrate the actual page logic into OOBE.

Bug:  884061 
Change-Id: Ie3bafefc736c25484e9b421648a090e9c1aa6906
Reviewed-on: https://chromium-review.googlesource.com/1223028
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594926}
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/chromeos/login/oobe_screen.cc
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/chromeos/login/oobe_screen.h
[add] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/chromeos/login/screens/multidevice_setup_screen.cc
[add] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/chromeos/login/screens/multidevice_setup_screen.h
[add] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/chromeos/login/screens/multidevice_setup_screen_view.h
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/chromeos/login/screens/screen_exit_code.cc
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/chromeos/login/screens/screen_exit_code.h
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/custom_elements_login.html
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/custom_elements_login.js
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/custom_elements_oobe.html
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/custom_elements_oobe.js
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/login.js
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/login_non_lock_shared.js
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/login_screens.html
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/md_login.js
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/md_login_screens.html
[add] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/multidevice_setup_first_run.html
[add] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/multidevice_setup_first_run.js
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/oobe_screens.html
[add] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/screen_multidevice_setup.html
[add] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/resources/chromeos/login/screen_multidevice_setup.js
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/ui/webui/chromeos/login/multidevice_setup_screen_handler.cc
[add] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/ui/webui/chromeos/login/multidevice_setup_screen_handler.h
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/e4485f206bf90c99f3cb281b63325cdbfc95a0be/chrome/browser/ui/webui/chromeos/login/oobe_ui.h

Status: Fixed (was: Started)

Sign in to add a comment