We should migrate to BindOnce/BindRepeating.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6347629cca3667eb9c3c680cf3c880bae849d670 commit 6347629cca3667eb9c3c680cf3c880bae849d670 Author: Charlie Harrison <csharrison@chromium.org> Date: Fri Sep 14 20:27:03 2018 Remove usage of base::Bind in async_document_subresource_filter This API is deprecated. Bind is replaced by BindOnce which is a semantics change, but shouldn't result in a behavior change. Bug: 884057 Change-Id: I06e728a88a84ed6e042e6f2e90f5a0ad9d40eecb Reviewed-on: https://chromium-review.googlesource.com/1225994 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#591455} [modify] https://crrev.com/6347629cca3667eb9c3c680cf3c880bae849d670/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.cc [modify] https://crrev.com/6347629cca3667eb9c3c680cf3c880bae849d670/components/subresource_filter/content/browser/async_document_subresource_filter.cc [modify] https://crrev.com/6347629cca3667eb9c3c680cf3c880bae849d670/components/subresource_filter/content/browser/async_document_subresource_filter.h [modify] https://crrev.com/6347629cca3667eb9c3c680cf3c880bae849d670/components/subresource_filter/content/browser/async_document_subresource_filter_test_utils.cc [modify] https://crrev.com/6347629cca3667eb9c3c680cf3c880bae849d670/components/subresource_filter/content/browser/async_document_subresource_filter_test_utils.h [modify] https://crrev.com/6347629cca3667eb9c3c680cf3c880bae849d670/components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc [modify] https://crrev.com/6347629cca3667eb9c3c680cf3c880bae849d670/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7907d86c487c43a22a499b2e8a834afeee91830 commit e7907d86c487c43a22a499b2e8a834afeee91830 Author: Charlie Harrison <csharrison@chromium.org> Date: Mon Sep 17 18:26:07 2018 Remove usage of base::Bind in the verified ruleset This API is deprecated. TBR=jkarlin@chromium.org Bug: 884057 Change-Id: I01b04bbb212f1ee9d157e85d2702be2a29f6b9c7 Reviewed-on: https://chromium-review.googlesource.com/1226307 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#591746} [modify] https://crrev.com/e7907d86c487c43a22a499b2e8a834afeee91830/components/subresource_filter/content/browser/verified_ruleset_dealer.cc [modify] https://crrev.com/e7907d86c487c43a22a499b2e8a834afeee91830/components/subresource_filter/content/browser/verified_ruleset_dealer.h [modify] https://crrev.com/e7907d86c487c43a22a499b2e8a834afeee91830/components/subresource_filter/content/browser/verified_ruleset_dealer_unittest.cc
Eric: wanna finish this up? I think the only other usage is in ruleset service.
Yep, I'll take that on now, seeing as the move went through.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6700409224d15347be974f0a53f03b8b780fc38a commit 6700409224d15347be974f0a53f03b8b780fc38a Author: Eric Robinson <ericrobinson@chromium.org> Date: Thu Sep 20 14:34:25 2018 Add "Once" to Bind/Closure/Callback in RulesetService. This updates the closures and callbacks to use the "Once" paradigm as per the style guide/presubmission warnings. All of the instances were switched over to "Once". Bug: 884057 Change-Id: I93a63e79c6e142051a80eea433f29239a1f3b28d Reviewed-on: https://chromium-review.googlesource.com/1234217 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#592795} [modify] https://crrev.com/6700409224d15347be974f0a53f03b8b780fc38a/chrome/browser/subresource_filter/test_ruleset_publisher.cc [modify] https://crrev.com/6700409224d15347be974f0a53f03b8b780fc38a/components/subresource_filter/content/browser/ruleset_service.cc [modify] https://crrev.com/6700409224d15347be974f0a53f03b8b780fc38a/components/subresource_filter/content/browser/ruleset_service.h [modify] https://crrev.com/6700409224d15347be974f0a53f03b8b780fc38a/components/subresource_filter/content/browser/ruleset_service_unittest.cc [modify] https://crrev.com/6700409224d15347be974f0a53f03b8b780fc38a/components/subresource_filter/core/browser/ruleset_service_delegate.h
Closing, as this should be the last of the usages.
Comment 1 by bugdroid1@chromium.org
, Sep 14