New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 884055 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Feature



Sign in to add a comment

Provide download API from ios/web_view

Project Member Reported by ichikawa@chromium.org, Sep 14

Issue description

Download links (e.g, a KML file) are not working in ios_web_view_shell.
Sample page: https://jsfiddle.net/w8g5fkdz/show

I guess I should create ios/web_view version of this class:
https://cs.chromium.org/chromium/src/ios/web/public/download/download_controller.h?l=29&rcl=a7de26a70c46693038d8651f821bf75d9d1473e6
then OnDownloadCreated is called when the user taps on a link which requires download.

Then we should expose this to CWVUIDelegate to allow clients to implement their download manager.
 
Cc: eugene...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/255540f5c30f51ffd62af01f308878b8ff4c77f6

commit 255540f5c30f51ffd62af01f308878b8ff4c77f6
Author: Hiroshi Ichikawa <ichikawa@chromium.org>
Date: Wed Nov 07 01:05:31 2018

Implement download API.

Bug:  884055 
Change-Id: Ib5a93bf85d877dfdaef7491a99295be305107398
Reviewed-on: https://chromium-review.googlesource.com/c/1318514
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605905}
[modify] https://crrev.com/255540f5c30f51ffd62af01f308878b8ff4c77f6/ios/web_view/BUILD.gn
[add] https://crrev.com/255540f5c30f51ffd62af01f308878b8ff4c77f6/ios/web_view/internal/cwv_download_task.mm
[add] https://crrev.com/255540f5c30f51ffd62af01f308878b8ff4c77f6/ios/web_view/internal/cwv_download_task_internal.h
[add] https://crrev.com/255540f5c30f51ffd62af01f308878b8ff4c77f6/ios/web_view/internal/cwv_download_task_unittest.mm
[modify] https://crrev.com/255540f5c30f51ffd62af01f308878b8ff4c77f6/ios/web_view/internal/web_view_browser_state.h
[modify] https://crrev.com/255540f5c30f51ffd62af01f308878b8ff4c77f6/ios/web_view/internal/web_view_browser_state.mm
[add] https://crrev.com/255540f5c30f51ffd62af01f308878b8ff4c77f6/ios/web_view/internal/web_view_download_manager.h
[add] https://crrev.com/255540f5c30f51ffd62af01f308878b8ff4c77f6/ios/web_view/internal/web_view_download_manager.mm
[add] https://crrev.com/255540f5c30f51ffd62af01f308878b8ff4c77f6/ios/web_view/public/cwv_download_task.h
[modify] https://crrev.com/255540f5c30f51ffd62af01f308878b8ff4c77f6/ios/web_view/public/cwv_navigation_delegate.h
[modify] https://crrev.com/255540f5c30f51ffd62af01f308878b8ff4c77f6/ios/web_view/shell/shell_view_controller.m

Status: Fixed (was: Started)

Sign in to add a comment