Move MultiDeviceSetup Mojo JS files to chrome://resources |
||||
Issue descriptionNow that the setup flow must be embedded in both chrome://oobe and chrome://multidevice-setup, it no longer makes sense to embed separate resources in each page. The MultiDeviceSetup-related files in [1] should be moved to appropriate locations: MultiDeviceSetup Mojo files: chrome://resources/cr_components/chromeos/multidevice_setup/* DeviceSync Mojo files: chrome://resources/cr_components/chromeos/device_sync/* Base Mojo files (i.e., time.mojom.js): TBD Note that this bug is different from issue 884041 , which deals with WebUI assets. [1] https://cs.chromium.org/chromium/src/chromeos/resources/chromeos_resources.grd
,
Sep 17
Turns out that the WebUI JavaScript resources depend on the Mojo files, so I need to finish this task before working on issue 884041 .
,
Sep 20
,
Sep 21
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93a81e474057e8bbc4d9ba26ef9806034085ff25 commit 93a81e474057e8bbc4d9ba26ef9806034085ff25 Author: Kyle Horimoto <khorimoto@google.com> Date: Fri Sep 21 23:30:50 2018 [CrOS MultiDevice] Serve relevant Mojo JS files from chrome://resources. The MultiDevice setup flow utilizes four Mojo JS files: time.mojom.js, device_sync.mojom.js, multidevice_setup.mojom.js, and multidevice_setup_constants.mojom.js. Previously, these files were added directly to the data source for chrome://multidevice-setup. Now that this UI is being shared between both chrome://multidevice-setup and chrome://oobe, the resources are moved to a shared location; namely, chrome://resources/js/*. Bug: 884048 Change-Id: Iea5806dc526482bf7c8904ad71512267055d48c7 Reviewed-on: https://chromium-review.googlesource.com/1231920 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#593376} [modify] https://crrev.com/93a81e474057e8bbc4d9ba26ef9806034085ff25/chrome/browser/resources/chromeos/multidevice_setup/mojo_api_behavior.html [modify] https://crrev.com/93a81e474057e8bbc4d9ba26ef9806034085ff25/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_dialog.cc [modify] https://crrev.com/93a81e474057e8bbc4d9ba26ef9806034085ff25/chromeos/components/proximity_auth/webui/proximity_auth_ui.cc [modify] https://crrev.com/93a81e474057e8bbc4d9ba26ef9806034085ff25/chromeos/components/proximity_auth/webui/resources/proximity_auth.html [modify] https://crrev.com/93a81e474057e8bbc4d9ba26ef9806034085ff25/chromeos/resources/BUILD.gn [modify] https://crrev.com/93a81e474057e8bbc4d9ba26ef9806034085ff25/chromeos/resources/chromeos_resources.grd [add] https://crrev.com/93a81e474057e8bbc4d9ba26ef9806034085ff25/chromeos/resources/multidevice_resources.grdp [modify] https://crrev.com/93a81e474057e8bbc4d9ba26ef9806034085ff25/content/browser/BUILD.gn [modify] https://crrev.com/93a81e474057e8bbc4d9ba26ef9806034085ff25/content/browser/webui/shared_resources_data_source.cc [modify] https://crrev.com/93a81e474057e8bbc4d9ba26ef9806034085ff25/extensions/renderer/dispatcher.cc [modify] https://crrev.com/93a81e474057e8bbc4d9ba26ef9806034085ff25/mojo/public/js/BUILD.gn [modify] https://crrev.com/93a81e474057e8bbc4d9ba26ef9806034085ff25/mojo/public/js/mojo_bindings_resources.grd |
||||
►
Sign in to add a comment |
||||
Comment 1 by khorimoto@chromium.org
, Sep 14